third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h - Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors (Closed)

Patch Set: Added UUID to DESCRIPTOR_NOT_FOUND, INVALID_DESCRIPTOR and INVALID_CHARACTERISTIC. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

index 2884d1f605b8996173f99ef441bd8add6deecda0..b3a8fcc94cf16efbcdd866a812a55562ebbfe580 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h

@@ -56,6 +56,7 @@ class BluetoothRemoteGATTService final

private:

void GetCharacteristicsCallback(

const String& serviceInstanceId,

+ const String& requestedCharacteristicUUID,

mojom::blink::WebBluetoothGATTQueryQuantity,

ScriptPromiseResolver*,

mojom::blink::WebBluetoothResult,