Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothError.h

Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors (Closed)
Patch Set: Added UUID to DESCRIPTOR_NOT_FOUND, INVALID_DESCRIPTOR and INVALID_CHARACTERISTIC. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/bluetooth/BluetoothError.h
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothError.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothError.h
index c9374283b4cf3b0de64c4c7daa985b68ac74b147..bf3cbce92652cbbc46a3973ec4d4679db5047250 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothError.h
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothError.h
@@ -12,7 +12,6 @@
namespace blink {
class DOMException;
-class ScriptPromiseResolver;
// BluetoothError is used with CallbackPromiseAdapter to receive
// WebBluetoothResult responses. See CallbackPromiseAdapter class comments.
@@ -20,9 +19,12 @@ class BluetoothError {
STATIC_ONLY(BluetoothError);
public:
- // Interface required by CallbackPromiseAdapter:
- static DOMException* take(ScriptPromiseResolver*,
- mojom::blink::WebBluetoothResult);
+ static DOMException* createDOMException(
+ mojom::blink::WebBluetoothResult error,
+ const String& detailedMessage);
+
+ static DOMException* createDOMException(
+ mojom::blink::WebBluetoothResult error);
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698