third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp - Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors (Closed)

Patch Set: Use CreateDOMException instead of take(). Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp b/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

index fb7cb82033326c960cad65268deda2b6ac2498a6..71c4970b9ce5e3681052fa58c4c564f32d695a8a 100644

--- a/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

@@ -150,7 +150,7 @@ void Bluetooth::RequestDeviceCallback(

getBluetoothDeviceRepresentingDevice(std::move(device), resolver);

resolver->resolve(bluetoothDevice);

} else {

- resolver->reject(BluetoothError::take(resolver, result));

+ resolver->reject(BluetoothError::CreateDOMException(result));

}