third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h - Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors (Closed)

Patch Set: Added comment and changed to enum class. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

index c4aaabd9435bbdd1197e7893c019e1d64242794c..ca7efb124a359d6d9c2b0374056fd9fd6a095514 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

@@ -118,6 +118,7 @@ class BluetoothRemoteGATTCharacteristic final

const String& descriptorUUID = String());

void GetDescriptorsCallback(

+ const String& requestedDescriptorUUID,

const String& characteristicInstanceId,

mojom::blink::WebBluetoothGATTQueryQuantity,

ScriptPromiseResolver*,

@@ -125,6 +126,8 @@ class BluetoothRemoteGATTCharacteristic final

Optional<Vector<mojom::blink::WebBluetoothRemoteGATTDescriptorPtr>>

descriptors);

+ DOMException* createInvalidCharacteristicError();

mojom::blink::WebBluetoothRemoteGATTCharacteristicPtr m_characteristic;

Member<BluetoothRemoteGATTService> m_service;

bool m_stopped;