Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html

Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors (Closed)
Patch Set: Added comment and changed to enum class. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/bluetooth/script-tests/server/device-disconnects-invalidates-objects.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html b/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html
index e78b249f76be28e6134564cee27bdc107cdedaae..99829022fb58b69703b546ef0d87444fd7455eb8 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html
@@ -4,6 +4,7 @@
<script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>
<script>
'use strict';
+ let descriptorUUID = '00002906-0000-1000-8000-00805f9b34fb';
promise_test(() => {
return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')
.then(() => requestDeviceWithKeyDown({
@@ -12,11 +13,12 @@ promise_test(() => {
.then(gattServer => gattServer.getPrimaryService('health_thermometer'))
.then(service => service.getCharacteristic('measurement_interval'))
.then(characteristic => {
- assert_promise_rejects_with_message(
+ return assert_promise_rejects_with_message(
// Valid Range is not present in this characteristic
- characteristic.getDescriptor(2906),
+ characteristic.getDescriptor(descriptorUUID),
new DOMException(
- 'No Descriptors with specified UUID found in Characteristic.',
+ 'No Descriptors matching UUID ' + descriptorUUID +
+ ' found in Characteristic with UUID ' + measurement_interval.uuid + '.',
'NotFoundError'));
})
}, 'Request for absent descriptor. Reject with NotFoundError.');
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/bluetooth/script-tests/server/device-disconnects-invalidates-objects.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698