third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-not-found-with-uuid.html - Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-not-found-with-uuid.html

Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors (Closed)

Patch Set: Added comment and changed to enum class. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-disconnect-invalidates-objects.html ('k') | third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-device-disconnects-invalidates-objects.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 let expected = new DOMException(	8 let expected = new DOMException(

9 'No Characteristics with specified UUID found in Service.',	9 'No Characteristics matching UUID ' + battery_level.uuid + ' found in Servic e with UUID ' +

	10 heart_rate.uuid + '.',

10 'NotFoundError');	11 'NotFoundError');

11 return setBluetoothFakeAdapter('HeartRateAdapter')	12 return setBluetoothFakeAdapter('HeartRateAdapter')

12 .then(() => requestDeviceWithKeyDown({	13 .then(() => requestDeviceWithKeyDown({

13 filters: [{services: ['heart_rate']}]}))	14 filters: [{services: ['heart_rate']}]}))

14 .then(device => device.gatt.connect())	15 .then(device => device.gatt.connect())

15 .then(gattServer => gattServer.getPrimaryService('heart_rate'))	16 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

16 .then(service => assert_promise_rejects_with_message(	17 .then(service => assert_promise_rejects_with_message(

17 service.getCharacteristics('battery_level'), expected));	18 service.getCharacteristics('battery_level'), expected));

18 }, 'Request for absent characteristics with UUID. Reject with NotFoundError.');	19 }, 'Request for absent characteristics with UUID. Reject with NotFoundError.');

19 </script>	20 </script>

OLD	NEW