bluetooth: show better error messages for services, characteristics and descriptors

third_party/WebKit/Source/modules/bluetooth/BluetoothError.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BluetoothError_h
 #define BluetoothError_h
 
 #include "platform/heap/Handle.h"
 #include "third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom-blink.h"
 #include "wtf/Allocator.h"
 
 namespace blink {
 
+// These error codes requires detailed error messages.
+enum BluetoothErrorCode {

[dcheng, 2017/02/28 05:09:51]

enum class or nest it inside the BluetoothError class. These names are generic
enough that we probably shouldn't have them in the global namespace.

(I'd suggest enum class since it seems like a lot of places already qualify it
with BluetoothErrorCode)

[perja, 2017/02/28 11:45:19]

Done.

+  InvalidService,
+  InvalidCharacteristic,
+  InvalidDescriptor,
+  ServiceNotFound,
+  CharacteristicNotFound,
+  DescriptorNotFound
+};
+
 class DOMException;
-class ScriptPromiseResolver;
 
 // BluetoothError is used with CallbackPromiseAdapter to receive
 // WebBluetoothResult responses. See CallbackPromiseAdapter class comments.
 class BluetoothError {
   STATIC_ONLY(BluetoothError);
 
  public:
-  // Interface required by CallbackPromiseAdapter:
-  static DOMException* take(ScriptPromiseResolver*,
-                            mojom::blink::WebBluetoothResult);
+  static DOMException* createDOMException(BluetoothErrorCode,
+                                          const String& detailedMessage);
+
+  static DOMException* createDOMException(
+      mojom::blink::WebBluetoothResult error);
 };
 
 }  // namespace blink
 
 #endif  // BluetoothError_h