bluetooth: show better error messages for services, characteristics and descriptors

third_party/WebKit/Source/modules/bluetooth/BluetoothError.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BluetoothError_h
 #define BluetoothError_h
 
 #include "platform/heap/Handle.h"
 #include "third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom-blink.h"
 #include "wtf/Allocator.h"
 
 namespace blink {
 
 class DOMException;
 class ScriptPromiseResolver;
 
 // BluetoothError is used with CallbackPromiseAdapter to receive
 // WebBluetoothResult responses. See CallbackPromiseAdapter class comments.
 class BluetoothError {
   STATIC_ONLY(BluetoothError);
 
  public:
   // Interface required by CallbackPromiseAdapter:
   static DOMException* take(ScriptPromiseResolver*,
                             mojom::blink::WebBluetoothResult);
+
+  static DOMException* take(

[ortuno, 2017/02/07 21:54:46]

I don't think it makes sense to keep using take. We needed it because of
CallbackPromiseAdapter which we no longer use. I think it would make more sense
to move CreateDOMException from BluetoothRemoteGATTUtils here and add enums for
the new types of errors.

[perja, 2017/02/08 15:05:47]

Done.

+      ScriptPromiseResolver*,
+      mojom::blink::WebBluetoothResult,
+      String detailedMessage /* Detailed error message - can be empty.*/);

[ortuno, 2017/02/07 21:54:46]

Also could this be an optional argument so we can use the same method?

[perja, 2017/02/08 15:05:47]

Done.

 };
 
 }  // namespace blink
 
 #endif  // BluetoothError_h