Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2680773002: Mark unittest tests as slow (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tests/compiler/dart2js/dart2js.status View 3 chunks +3 lines, -3 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-07 11:50:44 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2680773002/diff/1/tests/compiler/dart2js/dart2js.status File tests/compiler/dart2js/dart2js.status (right): https://codereview.chromium.org/2680773002/diff/1/tests/compiler/dart2js/dart2js.status#newcode9 tests/compiler/dart2js/dart2js.status:9: #kernel/visitor_test: SkipSlow # Times out. Issue #28581 delete?
3 years, 10 months ago (2017-02-07 23:14:43 UTC) #3
Johnni Winther
https://codereview.chromium.org/2680773002/diff/1/tests/compiler/dart2js/dart2js.status File tests/compiler/dart2js/dart2js.status (right): https://codereview.chromium.org/2680773002/diff/1/tests/compiler/dart2js/dart2js.status#newcode9 tests/compiler/dart2js/dart2js.status:9: #kernel/visitor_test: SkipSlow # Times out. Issue #28581 On 2017/02/07 ...
3 years, 10 months ago (2017-02-08 09:15:43 UTC) #4
Johnni Winther
3 years, 10 months ago (2017-02-08 09:20:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
85826aad35882ab7e12ec762b6d7fe7bc313317c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698