Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

Issue 2680743005: DevTools: Missing parenthesis on url in NetworkLog (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 var type = SDK.NetworkRequest.InitiatorType.Other; 121 var type = SDK.NetworkRequest.InitiatorType.Other;
122 var url = ''; 122 var url = '';
123 var lineNumber = -Infinity; 123 var lineNumber = -Infinity;
124 var columnNumber = -Infinity; 124 var columnNumber = -Infinity;
125 var scriptId = null; 125 var scriptId = null;
126 var initiator = request.initiator(); 126 var initiator = request.initiator();
127 127
128 if (request.redirectSource) { 128 if (request.redirectSource) {
129 type = SDK.NetworkRequest.InitiatorType.Redirect; 129 type = SDK.NetworkRequest.InitiatorType.Redirect;
130 url = request.redirectSource.url; 130 url = request.redirectSource.url();
131 } else if (initiator) { 131 } else if (initiator) {
132 if (initiator.type === Protocol.Network.InitiatorType.Parser) { 132 if (initiator.type === Protocol.Network.InitiatorType.Parser) {
133 type = SDK.NetworkRequest.InitiatorType.Parser; 133 type = SDK.NetworkRequest.InitiatorType.Parser;
134 url = initiator.url ? initiator.url : url; 134 url = initiator.url ? initiator.url : url;
135 lineNumber = initiator.lineNumber ? initiator.lineNumber : lineNumber; 135 lineNumber = initiator.lineNumber ? initiator.lineNumber : lineNumber;
136 } else if (initiator.type === Protocol.Network.InitiatorType.Script) { 136 } else if (initiator.type === Protocol.Network.InitiatorType.Script) {
137 for (var stack = initiator.stack; stack; stack = stack.parent) { 137 for (var stack = initiator.stack; stack; stack = stack.parent) {
138 var topFrame = stack.callFrames.length ? stack.callFrames[0] : null; 138 var topFrame = stack.callFrames.length ? stack.callFrames[0] : null;
139 if (!topFrame) 139 if (!topFrame)
140 continue; 140 continue;
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 SDK.PageLoad._lastIdentifier = 0; 317 SDK.PageLoad._lastIdentifier = 0;
318 318
319 /** @typedef {!{initiators: !Set<!SDK.NetworkRequest>, initiated: !Set<!SDK.Netw orkRequest>}} */ 319 /** @typedef {!{initiators: !Set<!SDK.NetworkRequest>, initiated: !Set<!SDK.Netw orkRequest>}} */
320 SDK.NetworkLog.InitiatorGraph; 320 SDK.NetworkLog.InitiatorGraph;
321 321
322 /** @typedef {!{type: !SDK.NetworkRequest.InitiatorType, url: string, lineNumber : number, columnNumber: number, scriptId: ?string}} */ 322 /** @typedef {!{type: !SDK.NetworkRequest.InitiatorType, url: string, lineNumber : number, columnNumber: number, scriptId: ?string}} */
323 SDK.NetworkLog._InitiatorInfo; 323 SDK.NetworkLog._InitiatorInfo;
324 324
325 SDK.NetworkLog._initiatorDataSymbol = Symbol('InitiatorData'); 325 SDK.NetworkLog._initiatorDataSymbol = Symbol('InitiatorData');
326 SDK.NetworkLog._pageLoadForRequestSymbol = Symbol('PageLoadForRequest'); 326 SDK.NetworkLog._pageLoadForRequestSymbol = Symbol('PageLoadForRequest');
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698