Issue 268073004: FLAG_max_new_space_size is in MB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268073004: FLAG_max_new_space_size is in MB. (Closed)

Created:
6 years, 7 months ago by Hannes Payer (out of office)

Modified:
6 years, 7 months ago

Reviewers:
mvstanton, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

FLAG_max_new_space_size is in MB. Plus, cleanup of the space - generation mess. More to do there... BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21148

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
M	src/api.cc	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/flag-definitions.h	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/heap.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/v8.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Hannes Payer (out of office)

This change needs more thought... I have to re-do it, properly.

6 years, 7 months ago (2014-05-05 15:16:42 UTC) #3

Hannes Payer (out of office)

6 years, 7 months ago (2014-05-05 16:33:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r21148 (presubmit successful).