Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/android/BUILD.gn

Issue 2680723003: Remove ENABLE_VR_SHELL compile-time define. (Closed)
Patch Set: Rename vr_shell_enabled_ Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 101078b8f8d8ad5eef68bd2309e1cfee4d14d5d4..b7fac6f3935d6931d0cc67c042675f1854bcbdf3 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -255,7 +255,7 @@ android_library("chrome_java") {
# From java_sources.gni.
java_files = chrome_java_sources
- if (enable_vr_shell || enable_webvr) {
agrieve 2017/02/08 01:31:27 Why not remove the definition in src/chrome/common
+ if (enable_webvr) {
java_files += chrome_vr_java_sources
deps += [ "//third_party/gvr-android-sdk:gvr_common_java" ]
}
@@ -458,17 +458,11 @@ android_library("chrome_test_java") {
android_library("chrome_test_vr_java") {
testonly = true
- java_files =
- [ "javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java" ]
-
- if (enable_vr_shell) {
- java_files += [
- "javatests/src/org/chromium/chrome/browser/vr_shell/MockVrDaydreamApi.java",
- "javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java",
- ]
- }
-
- # WebVR instrumentation files added conditionally here in future
+ java_files = [
+ "javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java",
+ "javatests/src/org/chromium/chrome/browser/vr_shell/MockVrDaydreamApi.java",
+ "javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java",
+ ]
deps = [
"//base:base_java",
@@ -788,7 +782,7 @@ instrumentation_test_apk("chrome_public_test_apk") {
proguard_enabled = !is_java_debug
}
-if (enable_webvr || enable_vr_shell) {
+if (enable_webvr) {
instrumentation_test_apk("chrome_public_test_vr_apk") {
apk_name = "ChromePublicTestVr"
apk_under_test = ":chrome_public_apk"
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698