Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6032)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2680723003: Remove ENABLE_VR_SHELL compile-time define. (Closed)
Patch Set: Fix lint warnings generated by vr_shell's new pickier checks. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 2c034fb1c1fac10a3412c33609b3c0ff1b390b01..2ee1234690de7cddf5e6976029331f6d74e70122 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -2292,10 +2292,7 @@ split_static_library("ui") {
"webui/webapks_ui.cc",
"webui/webapks_ui.h",
]
- if (enable_vr_shell || enable_webvr) {
- if (enable_vr_shell) {
- defines += [ "ENABLE_VR_SHELL" ]
- }
+ if (enable_webvr) {
sources += [
"webui/vr_shell/vr_shell_ui_message_handler.cc",
"webui/vr_shell/vr_shell_ui_message_handler.h",
@@ -2306,7 +2303,7 @@ split_static_library("ui") {
deps += [ "//chrome/browser/android/vr_shell:vr_common" ]
}
if (enable_vr_shell_ui_dev) {
- assert(enable_vr_shell)
+ assert(enable_webvr)
defines += [ "ENABLE_VR_SHELL_UI_DEV" ]
}
deps += [
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698