Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Unified Diff: chrome/browser/about_flags.cc

Issue 2680723003: Remove ENABLE_VR_SHELL compile-time define. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 31f3104c6251aa6187dc9b1878cf25621641bfe1..254036b9a53e3aadfa66ff4c536e58d5179cfe8f 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1598,11 +1598,9 @@ const FeatureEntry kFeatureEntries[] = {
#endif // OS_MACOSX
{"enable-webvr", IDS_FLAGS_WEBVR_NAME, IDS_FLAGS_WEBVR_DESCRIPTION, kOsAll,
SINGLE_VALUE_TYPE(switches::kEnableWebVR)},
-#if defined(ENABLE_VR_SHELL)
amp 2017/02/07 19:26:01 We only want this to show up on platforms that can
mthiesse 2017/02/07 19:33:26 +1, I think this is the only useful use of ENABLE_
cjgrant 2017/02/07 20:10:17 It's interesting though that the "enable-webvr" fl
amp 2017/02/07 20:23:10 Maybe it should be. I think I had that same quest
{"enable-vr-shell", IDS_FLAGS_ENABLE_VR_SHELL_NAME,
IDS_FLAGS_ENABLE_VR_SHELL_DESCRIPTION, kOsAndroid,
FEATURE_VALUE_TYPE(features::kVrShell)},
-#endif // ENABLE_VR_SHELL
#if defined(OS_CHROMEOS)
{"disable-accelerated-mjpeg-decode",
IDS_FLAGS_ACCELERATED_MJPEG_DECODE_NAME,

Powered by Google App Engine
This is Rietveld 408576698