Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: chrome/android/java/AndroidManifest.xml

Issue 2680723003: Remove ENABLE_VR_SHELL compile-time define. (Closed)
Patch Set: Fix lint warnings generated by vr_shell's new pickier checks. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/chrome_public_apk_tmpl.gni ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- 6 <!--
7 Note: This is a jinja2 template, processed at build time into the final manifest . 7 Note: This is a jinja2 template, processed at build time into the final manifest .
8 8
9 Blocks denoted with { % block some_name % }foo{ % endblock % } can be overridden 9 Blocks denoted with { % block some_name % }foo{ % endblock % } can be overridden
10 by a child template that "extends" this file. 10 by a child template that "extends" this file.
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 <uses-permission android:name="android.permission.NFC"/> 45 <uses-permission android:name="android.permission.NFC"/>
46 <uses-permission android:name="android.permission.READ_SYNC_SETTINGS"/> 46 <uses-permission android:name="android.permission.READ_SYNC_SETTINGS"/>
47 <uses-permission android:name="android.permission.READ_SYNC_STATS"/> 47 <uses-permission android:name="android.permission.READ_SYNC_STATS"/>
48 <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/> 48 <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/>
49 <uses-permission android:name="android.permission.RECORD_AUDIO"/> 49 <uses-permission android:name="android.permission.RECORD_AUDIO"/>
50 <uses-permission android:name="android.permission.USE_CREDENTIALS"/> 50 <uses-permission android:name="android.permission.USE_CREDENTIALS"/>
51 <uses-permission android:name="android.permission.VIBRATE"/> 51 <uses-permission android:name="android.permission.VIBRATE"/>
52 <uses-permission android:name="android.permission.WAKE_LOCK"/> 52 <uses-permission android:name="android.permission.WAKE_LOCK"/>
53 <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/> 53 <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
54 <uses-permission android:name="android.permission.WRITE_SYNC_SETTINGS"/> 54 <uses-permission android:name="android.permission.WRITE_SYNC_SETTINGS"/>
55 {% set enable_vr_shell = enable_vr_shell|default(0) %}
56 {% set enable_webvr = enable_webvr|default(0) %} 55 {% set enable_webvr = enable_webvr|default(0) %}
57 {% if enable_vr_shell == "true" or enable_webvr == "true" %} 56 {% if enable_webvr == "true" %}
58 <!-- Required to read the paired viewer's distortion parameters. --> 57 <!-- Required to read the paired viewer's distortion parameters. -->
59 <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/> 58 <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
60 <!-- Indicates use of Android's VR-mode, available only on Android N+. --> 59 <!-- Indicates use of Android's VR-mode, available only on Android N+. -->
61 <uses-feature android:name="android.software.vr.mode" android:required="fals e"/> 60 <uses-feature android:name="android.software.vr.mode" android:required="fals e"/>
62 <!-- Indicates use of VR features that are available only on Daydream-ready devices. --> 61 <!-- Indicates use of VR features that are available only on Daydream-ready devices. -->
63 <uses-feature android:name="android.hardware.vr.high_performance" android:re quired="false"/> 62 <uses-feature android:name="android.hardware.vr.high_performance" android:re quired="false"/>
64 {% endif %} 63 {% endif %}
65 64
66 <permission android:name="{{ manifest_package }}.permission.CHILD_SERVICE" a ndroid:protectionLevel="signature" /> 65 <permission android:name="{{ manifest_package }}.permission.CHILD_SERVICE" a ndroid:protectionLevel="signature" />
67 <permission android:name="{{ manifest_package }}.permission.READ_WRITE_BOOKM ARK_FOLDERS" android:protectionLevel="signatureOrSystem" /> 66 <permission android:name="{{ manifest_package }}.permission.READ_WRITE_BOOKM ARK_FOLDERS" android:protectionLevel="signatureOrSystem" />
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 filter. We need to add these filters here as well, or non-presenti ng webVR pages will 368 filter. We need to add these filters here as well, or non-presenti ng webVR pages will
370 trigger a daydream incompatible app message. 369 trigger a daydream incompatible app message.
371 --> 370 -->
372 <intent-filter> 371 <intent-filter>
373 <action android:name="org.chromium.chrome.browser.dummy.action" /> 372 <action android:name="org.chromium.chrome.browser.dummy.action" />
374 <category android:name="com.google.intent.category.DAYDREAM" /> 373 <category android:name="com.google.intent.category.DAYDREAM" />
375 <category android:name="com.google.intent.category.CARDBOARD" /> 374 <category android:name="com.google.intent.category.CARDBOARD" />
376 </intent-filter> 375 </intent-filter>
377 </activity> 376 </activity>
378 377
379 {% if enable_vr_shell == "true" or enable_webvr == "true" %} 378 {% if enable_webvr == "true" %}
380 <!-- 379 <!--
381 TODO(mthiesse): Temporarily skip ChromeLauncherActivity when returni ng from Daydream 380 TODO(mthiesse): Temporarily skip ChromeLauncherActivity when returni ng from Daydream
382 DON flow to avoid polluting metrics. 381 DON flow to avoid polluting metrics.
383 --> 382 -->
384 <activity-alias android:name="org.chromium.chrome.browser.VRChromeTabbed Activity" 383 <activity-alias android:name="org.chromium.chrome.browser.VRChromeTabbed Activity"
385 android:targetActivity="org.chromium.chrome.browser.ChromeTabbedActi vity" 384 android:targetActivity="org.chromium.chrome.browser.ChromeTabbedActi vity"
386 android:enableVrMode="@string/gvr_vr_mode_component"> 385 android:enableVrMode="@string/gvr_vr_mode_component">
387 <!-- 386 <!--
388 Daydream api categorizes an activity to three categories: Cardboar d only, hybrid 387 Daydream api categorizes an activity to three categories: Cardboar d only, hybrid
389 or Daydream. It does so by testing if intents can be resolved by t he activity 388 or Daydream. It does so by testing if intents can be resolved by t he activity
(...skipping 544 matching lines...) Expand 10 before | Expand all | Expand 10 after
934 choose the first MediaRouteController that can play it, so the orde r of the list can be important. 933 choose the first MediaRouteController that can play it, so the orde r of the list can be important.
935 The most specific MediaRouteControllers should be listed first, fol lowed by more generic ones. 934 The most specific MediaRouteControllers should be listed first, fol lowed by more generic ones.
936 The downstream manifest replaces this block, and hence replaces the list of media route 935 The downstream manifest replaces this block, and hence replaces the list of media route
937 controllers with its own list. --> 936 controllers with its own list. -->
938 <meta-data android:name="org.chromium.content.browser.REMOTE_MEDIA_PLAYE RS" 937 <meta-data android:name="org.chromium.content.browser.REMOTE_MEDIA_PLAYE RS"
939 android:value="org.chromium.chrome.browser.media.remote.DefaultMedia RouteController"/> 938 android:value="org.chromium.chrome.browser.media.remote.DefaultMedia RouteController"/>
940 939
941 {% endblock %} 940 {% endblock %}
942 </application> 941 </application>
943 </manifest> 942 </manifest>
OLDNEW
« no previous file with comments | « chrome/android/chrome_public_apk_tmpl.gni ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698