Generalize ScopedRegisteredURL as ScoedMockedURL*

third_party/WebKit/Source/platform/testing/URLTestHelpers.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 16 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef URLTestHelpers_h
 #define URLTestHelpers_h
 
 #include "platform/weborigin/KURL.h"
 #include "public/platform/WebString.h"
 #include "public/platform/WebURL.h"
+#include "public/platform/WebURLResponse.h"
 
 namespace blink {
-
-class WebURLResponse;
-
 namespace URLTestHelpers {
 
 inline blink::KURL toKURL(const std::string& url) {
   WTF::String wtfString(url.c_str());
   return blink::KURL(blink::ParsedURLString, wtfString);
 }
 
+// Note: Please use one of ScopedMockedURL* class for new code as you can as
+// possible.

[kinuko, 2017/02/08 08:21:48]

I think we could say

"Avoid directly using these methods, instead please use ScopedMockedURL (or
define a variant of ScopedMockedURL classes if necessary) in new code."

and remove unused code from this CL for now.

[Takashi Toyoshima, 2017/02/08 10:33:14]

Done.

+//
 // Helper functions for mock URLs. These functions set up the desired URL and
 // mimeType, with a 200 OK return status.
 // webTestDataPath() or platformTestDataPath() in UnitTestHelpers can be used to
 // get the appropriate |basePath| and |filePath| for test data directories.
 //  - For the mock URL, fullURL == baseURL + fileName.
 //  - For the file path, filePath == basePath + ("/" +) fileName.
 
 // Registers from a base URL and a base file path, and returns a calculated full
 // URL.
 WebURL registerMockedURLLoadFromBase(
     const WebString& baseURL,
     const WebString& basePath,
     const WebString& fileName,
     const WebString& mimeType = WebString::fromUTF8("text/html"));
 
 // Registers from a full URL and a full file path.
 void registerMockedURLLoad(
     const WebURL& fullURL,
     const WebString& filePath,
     const WebString& mimeType = WebString::fromUTF8("text/html"));
+
+// Registers with a custom response.
 void registerMockedURLLoadWithCustomResponse(const WebURL& fullURL,
                                              const WebString& filePath,
                                              WebURLResponse);
 
 // Registers a mock URL that returns a 404 error.
 void registerMockedErrorURLLoad(const WebURL& fullURL);
 
 }  // namespace URLTestHelpers
 }  // namespace blink
 
 #endif