Generalize ScopedRegisteredURL as ScoedMockedURL*

third_party/WebKit/Source/platform/testing/ScopedMockedURL.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ScopedMockedURL_h
+#define ScopedMockedURL_h
+
+#include "public/platform/WebString.h"
+#include "public/platform/WebURL.h"
+#include "public/platform/WebURLResponse.h"
+
+namespace blink {
+
+namespace testing {
+
+// Convenience classes that register a mocked URL on construction, and
+// unregisters it on destruction. This allows for a test to use constructs like

[kinuko, 2017/02/08 08:21:48]

nit: unregisters -> unregister

allows for a test to use constructors like ASSERT_TRUE() ->
allows tests to use the constructors, e.g. for ASSERT_TRUE(), without...

?

[Takashi Toyoshima, 2017/02/08 10:33:14]

As discussed offline, this second sentence looks trivial for ScopedX users.
(and original intention is a little unclear, maybe constructs was typo of
contracts?)
Let's remove.

+// ASSERT_TRUE() without needing to worry abount unregistering the mocked URL

[kinuko, 2017/02/08 08:21:48]

abount -> about

[Takashi Toyoshima, 2017/02/08 10:33:13]

Done.

+// load to avoid putting other tests into inconsistent states in case the
+// assertion fails.
+class ScopedMockedURL {
+ public:
+  explicit ScopedMockedURL(const WebURL&);

[Takashi Toyoshima, 2017/02/08 06:47:20]

We could have multiple constructor instead of having subclasses, but argument
sets are similar, and may be easy to use unexpected constructor, .e.g.
-LoadFromBase takes 3 or 4 WebString, -Load takes 1 WebURL + 1 or 2 WebString,
and three string literal arguments could be vague expression here.

+  virtual ~ScopedMockedURL();
+
+ private:
+  WebURL m_url;
+};
+
+class ScopedMockedURLLoadFromBase : ScopedMockedURL {
+ public:
+  ScopedMockedURLLoadFromBase(
+      const WebString& baseURL,
+      const WebString& basePath,
+      const WebString& fileName,
+      const WebString& mimeType = WebString::fromUTF8("text/html"));
+  ~ScopedMockedURLLoadFromBase() override = default;
+};
+
+class ScopedMockedURLLoad : ScopedMockedURL {
+ public:
+  ScopedMockedURLLoad(
+      const WebURL& fullURL,
+      const WebString& filePath,
+      const WebString& mimeType = WebString::fromUTF8("text/html"));
+  ~ScopedMockedURLLoad() override = default;
+};
+
+class ScopedMockedURLLoadWithCustomResponse : ScopedMockedURL {
+ public:
+  ScopedMockedURLLoadWithCustomResponse(const WebURL& fullURL,
+                                        const WebString& filePath,
+                                        WebURLResponse);
+  ~ScopedMockedURLLoadWithCustomResponse() override = default;
+};
+
+class ScopedMockedErrorURLLoad : ScopedMockedURL {
+ public:
+  ScopedMockedErrorURLLoad(const WebURL& fullURL);
+  ~ScopedMockedErrorURLLoad() override = default;
+};

[kinuko, 2017/02/08 08:21:48]

Could we avoid defining unused classes yet?  We can add these later when we need
them.

[Takashi Toyoshima, 2017/02/08 10:33:13]

Done.

+
+}  // namespace testing
+
+}  // namespace blink
+
+#endif