Generalize ScopedRegisteredURL as ScoedMockedURL*

third_party/WebKit/Source/platform/testing/URLTestHelpers.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 44 matching lines @@
 
 // Registers from a base URL and a base file path, and returns a calculated full
 // URL.
 WebURL registerMockedURLLoadFromBase(
     const WebString& baseURL,
     const WebString& basePath,
     const WebString& fileName,
     const WebString& mimeType = WebString::fromUTF8("text/html"));
 
 // Registers from a full URL and a full file path.
-void registerMockedURLLoad(
+WebURL registerMockedURLLoad(
     const WebURL& fullURL,
     const WebString& filePath,
     const WebString& mimeType = WebString::fromUTF8("text/html"));
-void registerMockedURLLoadWithCustomResponse(const WebURL& fullURL,
-                                             const WebString& filePath,
-                                             WebURLResponse);
+WebURL registerMockedURLLoadWithCustomResponse(const WebURL& fullURL,
+                                               const WebString& filePath,
+                                               WebURLResponse);
 
 // Registers a mock URL that returns a 404 error.
-void registerMockedErrorURLLoad(const WebURL& fullURL);
+WebURL registerMockedErrorURLLoad(const WebURL& fullURL);

[kinuko, 2017/02/07 11:17:38]

To me making these methods return the given fullURL doesn't feel very
intuitive... could we make the scoped class work without doing so?

[Takashi Toyoshima, 2017/02/08 06:47:20]

Done.

 
 }  // namespace URLTestHelpers
+
+// Convenience class that takes a mocked URL and unregisters it on destruction.
+// This allows for a test to use constructs like ASSERT_TRUE() without needing
+// to worry abount unregistering the mocked URL load to avoid putting other
+// tests into inconsistent states in case the assertion fails.
+class ScopedMockedURL {
+ public:
+  explicit ScopedMockedURL(const WebURL&);
+  ~ScopedMockedURL();
+
+ private:
+  WebURL m_url;
+};
+
 }  // namespace blink
 
 #endif