Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2680703004: Wait for sampling to complete before destructing. (Closed)

Created:
3 years, 10 months ago by bcwhite
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wait for sampling to complete before destructing. Merged into https://codereview.chromium.org/2554123002/ BUG=671716

Patch Set 1 #

Patch Set 2 : cleanup, comments, and fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -141 lines) Patch
M base/profiler/stack_sampling_profiler.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M base/profiler/stack_sampling_profiler.cc View 1 7 chunks +35 lines, -100 lines 0 comments Download
M base/profiler/stack_sampling_profiler_unittest.cc View 1 6 chunks +8 lines, -32 lines 0 comments Download

Depends on Patchset:

Issue 2554123002 Patch 560001

Messages

Total messages: 9 (9 generated)
bcwhite
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-07 23:04:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680703004/1
3 years, 10 months ago (2017-02-07 23:04:49 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-08 00:36:59 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/362039)
3 years, 10 months ago (2017-02-08 00:37:00 UTC) #4
bcwhite
The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-08 14:20:37 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680703004/20001
3 years, 10 months ago (2017-02-08 14:21:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-08 15:48:58 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/307066)
3 years, 10 months ago (2017-02-08 15:48:58 UTC) #8
bcwhite
3 years, 10 months ago (2017-02-14 14:34:06 UTC) #9 
Description was changed from

==========
Wait for sampling to complete before destructing.

BUG=671716
==========

to

==========
Wait for sampling to complete before destructing.

Merged into https://codereview.chromium.org/2554123002/

BUG=671716
==========

Powered by Google App Engine
This is Rietveld 408576698