third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp - Issue 2680683003: Remove faulty assertion in LayoutSVGResourceContainer::registerResource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp

Issue 2680683003: Remove faulty assertion in LayoutSVGResourceContainer::registerResource (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/masking/mask-valid-reference-wrong-element-type-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp

index 525258e73ffd5fd3381924bcb7ff2de62456ce8d..fe3dd9268d9e859d45e7860bb3b3f92379d66b4f 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp

@@ -230,8 +230,7 @@ void LayoutSVGResourceContainer::registerResource() {

LayoutObject* layoutObject = pendingClient->layoutObject();

if (!layoutObject)

continue;

- DCHECK(layoutObject->isSVG() && (resourceType() != FilterResourceType ||

- !layoutObject->isSVGRoot()));

+ DCHECK(layoutObject->isSVG());

StyleDifference diff;

diff.setNeedsFullLayout();

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/masking/mask-valid-reference-wrong-element-type-crash-expected.txt ('k') | no next file » | no next file with comments »