Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 268063008: Replace NewFunctionWithPrototype(name, prototype) by NewFunction(name) (Closed)

Created:
6 years, 7 months ago by Toon Verwaest
Modified:
6 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Replace NewFunctionWithPrototype(name, prototype) by NewFunction(name) BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -64 lines) Patch
M src/bootstrapper.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M src/factory.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/factory.cc View 3 chunks +9 lines, -13 lines 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +4 lines, -15 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +1 line, -5 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-weaksets.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 7 months ago (2014-05-06 13:42:47 UTC) #1
Igor Sheludko
nice! lgtm
6 years, 7 months ago (2014-05-07 17:48:20 UTC) #2
Toon Verwaest
6 years, 7 months ago (2014-05-09 16:39:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698