[dart:io] Extract better error messages from boringssl.

[dart:io] Extract better error messages from boringssl.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/b0749b1e60508537b1bb53846bed23462805bf5f

[zra, 2017-02-06 22:02:24]

zra@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-02-06 22:57:37]

lgtm

https://codereview.chromium.org/2680513004/diff/60001/runtime/bin/secure_sock...
File runtime/bin/secure_socket_boringssl.cc (right):

https://codereview.chromium.org/2680513004/diff/60001/runtime/bin/secure_sock...
runtime/bin/secure_socket_boringssl.cc:94: if (ssl &&
ssl != NULL

[zra, 2017-02-07 15:45:15]

https://codereview.chromium.org/2680513004/diff/60001/runtime/bin/secure_sock...
File runtime/bin/secure_socket_boringssl.cc (right):

https://codereview.chromium.org/2680513004/diff/60001/runtime/bin/secure_sock...
runtime/bin/secure_socket_boringssl.cc:94: if (ssl &&
On 2017/02/06 22:57:37, rmacnak wrote:
> ssl != NULL

Done.

[zra, 2017-02-07 15:45:26]

Description was changed from

==========
[dart:io] Extract better error messages from boringssl.
==========

to

==========
[dart:io] Extract better error messages from boringssl.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b0749b1e60508537b1bb53846bed23462805bf5f
==========

[zra, 2017-02-07 15:45:27]

Committed patchset #5 (id:80001) manually as
b0749b1e60508537b1bb53846bed23462805bf5f (presubmit successful).

[davidben, 2017-02-08 00:16:18]

davidben@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2017-02-08 00:16:19]

https://codereview.chromium.org/2680513004/diff/80001/runtime/bin/secure_sock...
File runtime/bin/secure_socket_boringssl.cc (right):

https://codereview.chromium.org/2680513004/diff/80001/runtime/bin/secure_sock...
runtime/bin/secure_socket_boringssl.cc:95: (error == ERR_PACK(ERR_R_SSL_LIB,
SSL_R_CERTIFICATE_VERIFY_FAILED))) {
Small drive-by comment. This would be a better way to do this:

ERR_GET_LIB(error) == ERR_LIB_SSL &&
ERR_GET_REASON(error) == SSL_R_CERTIFICATE_VERIFY_FAILED

I'll go update the docs to make it clearer which one we prefer. I see we put
both in the "Private functions" bucket which isn't especially helpful.

[zra, 2017-02-08 18:45:02]

https://codereview.chromium.org/2680513004/diff/80001/runtime/bin/secure_sock...
File runtime/bin/secure_socket_boringssl.cc (right):

https://codereview.chromium.org/2680513004/diff/80001/runtime/bin/secure_sock...
runtime/bin/secure_socket_boringssl.cc:95: (error == ERR_PACK(ERR_R_SSL_LIB,
SSL_R_CERTIFICATE_VERIFY_FAILED))) {
On 2017/02/08 00:16:19, davidben wrote:
> Small drive-by comment. This would be a better way to do this:
> 
> ERR_GET_LIB(error) == ERR_LIB_SSL &&
> ERR_GET_REASON(error) == SSL_R_CERTIFICATE_VERIFY_FAILED
> 
> I'll go update the docs to make it clearer which one we prefer. I see we put
> both in the "Private functions" bucket which isn't especially helpful.

Thanks for the suggestion! https://codereview.chromium.org/2683703004/