Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 268043002: ui: Move more gfx unit tests into gfx_unittests target. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

ui: Move more gfx unit tests into gfx_unittests target. These are non problematic tests that do not require any extra setup and do not depend on any global state, so it is safe to move straightforward to gfx_unittests. BUG=331829 TEST=ui_unittests, gfx_unittests TBR=danakj@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M ui/gfx/gfx.gyp View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/ui_unittests.gyp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 7 months ago (2014-05-04 21:55:26 UTC) #1
danakj
LGTM
6 years, 7 months ago (2014-05-05 15:49:11 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-05 15:49:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/268043002/1
6 years, 7 months ago (2014-05-05 15:49:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-05 17:06:58 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 18:12:17 UTC) #6
Message was sent while issue was closed.
Change committed as 268223

Powered by Google App Engine
This is Rietveld 408576698