ui/webui/resources/PRESUBMIT.py - Issue 2680413002: Turn on clang format as an upload step for all the repo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/PRESUBMIT.py

Issue 2680413002: Turn on clang format as an upload step for all the repo. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import re	5 import re

6	6

7	7

8 def PostUploadHook(cl, change, output_api):	8 def PostUploadHook(cl, change, output_api):

9 rietveld_obj = cl.RpcServer()	9 rietveld_obj = cl.RpcServer()

10 description = rietveld_obj.get_description(cl.issue)	10 description = rietveld_obj.get_description(cl.issue)

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
68 return [output_api.PresubmitError("\n".join(errors) + """	68 return [output_api.PresubmitError("\n".join(errors) + """

69	69

70 Don't embed translations directly in shared UI code. Instead, inject your	70 Don't embed translations directly in shared UI code. Instead, inject your

71 translation from the place using the shared code. For an example: see	71 translation from the place using the shared code. For an example: see

72 <cr-dialog>#closeText (http://bit.ly/2eLEsqh).""")]	72 <cr-dialog>#closeText (http://bit.ly/2eLEsqh).""")]

73	73

74	74

75 def _CommonChecks(input_api, output_api):	75 def _CommonChecks(input_api, output_api):

76 results = []	76 results = []

77 results += _CheckForTranslations(input_api, output_api)	77 results += _CheckForTranslations(input_api, output_api)

78 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api,

79 check_js=True)
Dan Beam 2017/02/10 22:54:13 why did you remove this? note the check_js=True why did you remove this? note the check_js=True jam 2017/02/10 22:59:39 oops, that was by accident. I'll restore this and Show quoted text On 2017/02/10 22:54:13, Dan Beam wrote: > why did you remove this? note the check_js=True oops, that was by accident. I'll restore this and the other callsite, thanks for pointing it out.
80 return results	78 return results

OLD	NEW

« PRESUBMIT.py ('K') | « ui/ozone/PRESUBMIT.py ('k') | no next file » | no next file with comments »