Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(140)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: ios/shared/DEPS
Issue
2680403005
:
Introduce WebStateList to manage a list of web::WebState. (Closed)
Patch Set: Rebase.
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
ios/chrome/test/BUILD.gn
ios/shared/DEPS
ios/shared/chrome/browser/tabs/BUILD.gn
ios/shared/chrome/browser/tabs/web_state_list.h
ios/shared/chrome/browser/tabs/web_state_list.mm
ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper.h
ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper.mm
ios/shared/chrome/browser/tabs/web_state_list_fast_enumeration_helper_unittest.mm
ios/shared/chrome/browser/tabs/web_state_list_observer.h
ios/shared/chrome/browser/tabs/web_state_list_observer_bridge.h
ios/shared/chrome/browser/tabs/web_state_list_observer_bridge.mm
ios/shared/chrome/browser/tabs/web_state_list_unittest.mm
View unified diff
|
Download patch
« no previous file with comments
|
« ios/chrome/test/BUILD.gn
('k') |
ios/shared/chrome/browser/tabs/BUILD.gn »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2
# Shared code between ios/chrome and ios/clean/chrome must not depend on them.
2
"+ios/web/public",
3
"+net",
4
5
# Code in ios/shared is used by both ios/chrome and ios/clean/chrome, so
6
# forbid circular dependencies.
3 "-ios/clean/chrome",
7 "-ios/clean/chrome",
4 "-ios/chrome",
8 "-ios/chrome",
5 ]
9 ]
OLD
NEW
« no previous file with comments
|
« ios/chrome/test/BUILD.gn
('k') |
ios/shared/chrome/browser/tabs/BUILD.gn »
('j') |
no next file with comments »
Issue 2680403005: Introduce WebStateList to manage a list of web::WebState. (Closed)
Created 3 years, 10 months ago by sdefresne
Modified 3 years, 10 months ago
Reviewers: marq (ping after 24h), rohitrao (ping after 24h), mef
Base URL:
Comments: 32
This is Rietveld
408576698