Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2680373002: Extract hints generation into a separte method and make is optional. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract hints generation into a separte method and make is optional. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b6f6738b77cc42be9675b9dc85f1e75482bf7b2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -64 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/analysis_impl.dart View 4 chunks +65 lines, -64 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-08 18:49:22 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-08 19:41:21 UTC) #2
scheglov
3 years, 10 months ago (2017-02-08 19:44:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6f6738b77cc42be9675b9dc85f1e75482bf7b2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698