third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt - Issue 2680353005: WebContents created via ctrl-click should be in a new process (target=_blank).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt

Issue 2680353005: WebContents created via ctrl-click should be in a new process (target=_blank). (Closed)

Patch Set: Change layout test expectations to match product code changes. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank.html ('K') | « third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank.html ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt

diff --git a/third_party/WebKit/LayoutTests/fast/loader/create-view-target-blank-expected.txt b/third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt

similarity index 72%

rename from third_party/WebKit/LayoutTests/fast/loader/create-view-target-blank-expected.txt

rename to third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt

index f7fa4017d025397d2d4c6b178be128068358a2bb..2c2af9b778a52fe5318ae4e1577f4a96b65f9054 100644

--- a/third_party/WebKit/LayoutTests/fast/loader/create-view-target-blank-expected.txt

+++ b/third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt

@@ -1,4 +1,4 @@

-createView(done.html)

+Default policy for navigation to 'done.html' is 'new background tab'

Łukasz Anforowicz 2017/04/14 19:29:10 Since this test is no longer going through CreateW

This test opens a new window by middle-clicking on a link with target=_blank. It passes, if the WebViewClient::createView method was invoked with the parameter "done.html".

link