Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2680353005: WebContents created via ctrl-click should be in a new process (target=_blank). (Closed)
Patch Set: Rebasing updating LayoutTest/FlagExpectations to account for test name change. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index c852f3a22322e7def1bdf773f53624557cb5ed30..bde3d1a7841a587a97bff85e06301baa914cd97b 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -987,12 +987,13 @@ void FrameLoader::Load(const FrameLoadRequest& passed_request,
if (policy == kNavigationPolicyDownload) {
Client()->LoadURLExternally(request.GetResourceRequest(),
kNavigationPolicyDownload, String(), false);
- } else {
+ return; // Navigation/download will be handled by the client.
+ } else if (ShouldNavigateTargetFrame(policy)) {
request.GetResourceRequest().SetFrameType(
WebURLRequest::kFrameTypeAuxiliary);
CreateWindowForRequest(request, *frame_, policy);
+ return; // Navigation will be handled by the new frame/window.
}
- return;
}
if (!frame_->IsNavigationAllowed())
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698