third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank.html - Issue 2680353005: WebContents created via ctrl-click should be in a new process (target=_blank).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank.html

Issue 2680353005: WebContents created via ctrl-click should be in a new process (target=_blank). (Closed)

Patch Set: Change layout test expectations to match product code changes. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/events/isolated-worlds-override-keystate-expected.txt ('K') | « third_party/WebKit/LayoutTests/fast/loader/create-view-target-blank-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 if (window.testRunner) {	4 if (window.testRunner) {

5 testRunner.dumpAsText();	5 testRunner.dumpAsText();

6 testRunner.dumpCreateView();	6 testRunner.dumpCreateView();

	7 testRunner.dumpNavigationPolicy();
	Łukasz Anforowicz 2017/04/14 19:29:10 This artificially preserves test coverage to get t This artificially preserves test coverage to get the new message in test results (see the changes in test expectations). TBH, I am not sure if this test is really needed / valuable - it seems to test implementation details, not things that an end-user would care about. Maybe we should remove this test and say that it is being replaced by the browser tests being added in this CL?
7 testRunner.setCanOpenWindows();	8 testRunner.setCanOpenWindows();

8 testRunner.setCloseRemainingWindowsWhenComplete();	9 testRunner.setCloseRemainingWindowsWhenComplete();

9 testRunner.waitUntilDone();	10 testRunner.waitUntilDone();

10 }	11 }

11	12

12 function runTest() {	13 function runTest() {

13 var link = document.getElementById("link");	14 var link = document.getElementById("link");

14 var middleMouseButton = 1;	15 var middleMouseButton = 1;

15 eventSender.mouseMoveTo(link.offsetLeft + 2, link.offsetTop + 2);	16 eventSender.mouseMoveTo(link.offsetLeft + 2, link.offsetTop + 2);

16 eventSender.mouseDown(middleMouseButton);	17 eventSender.mouseDown(middleMouseButton);

17 eventSender.mouseUp(middleMouseButton);	18 eventSender.mouseUp(middleMouseButton);

18 }	19 }

19 </script>	20 </script>

20 </head>	21 </head>

21 <body onload="runTest()">	22 <body onload="runTest()">

22 <div>	23 <div>

23 <p>	24 <p>

24 This test opens a new window by middle-clicking on a link with	25 This test opens a new window by middle-clicking on a link with

25 target=_blank. It passes, if the WebViewClient::createView method was	26 target=_blank. It passes, if the WebViewClient::createView method was

26 invoked with the parameter "done.html".	27 invoked with the parameter "done.html".

27 </p>	28 </p>

28 <p>	29 <p>

29 <a href="resources/done.html" id="link" target="_blank">link</a>	30 <a href="resources/done.html" id="link" target="_blank">link</a>

30 </p>	31 </p>

31 </div>	32 </div>

32 </body>	33 </body>

33 </html>	34 </html>

OLD	NEW