WebContents created via ctrl-click should be in a new process (target=_blank).

chrome/browser/chrome_navigation_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
@@ skipping 171 matching lines @@
       browser()->tab_strip_model()->GetWebContentsAt(1);
   ASSERT_NE(new_web_contents, web_contents);
   WaitForLoadStop(new_web_contents);
 
   GURL view_frame_source_url(content::kViewSourceScheme + std::string(":") +
                              iframe_target_url.spec());
   EXPECT_EQ(url_formatter::FormatUrl(view_frame_source_url),
             new_web_contents->GetTitle());
 }
 
+class CtrlClickShouldEndUpInNewProcessTest
+    : public ChromeNavigationBrowserTest,
+      public ::testing::WithParamInterface<const char*> {};

[Charlie Reis, 2017/04/14 22:39:28]

Personally I find parameterized tests really confusing to read/run/debug.  Would
it be roughly equivalent to use a lambda in the test itself and call it with
each anchor name?

[Łukasz Anforowicz, 2017/04/20 01:15:13]

I've switched to separate tests that call to a shared/common method in patchset
#5.

+
 // Verify that ctrl-click results 1) open up in a new renderer process
 // (https://crbug.com/23815) and 2) are in a new browsing instance (e.g.
 // cannot find the opener's window by name - https://crbug.com/658386).
-IN_PROC_BROWSER_TEST_F(ChromeNavigationBrowserTest,
-                       CtrlClickShouldEndUpInNewProcess) {
+IN_PROC_BROWSER_TEST_P(CtrlClickShouldEndUpInNewProcessTest, Test) {
   // Navigate to the test page.
   GURL main_url(embedded_test_server()->GetURL(
       "/frame_tree/anchor_to_same_site_location.html"));
   ui_test_utils::NavigateToURL(browser(), main_url);
 
   // Verify that there is only 1 active tab (with the right contents committed).
   EXPECT_EQ(0, browser()->tab_strip_model()->active_index());
   content::WebContents* main_contents =
       browser()->tab_strip_model()->GetWebContentsAt(0);
   EXPECT_EQ(main_url, main_contents->GetLastCommittedURL());
 
   // Ctrl-click the anchor/link in the page.
   content::WebContents* new_contents = nullptr;
   {
     content::WebContentsAddedObserver new_tab_observer;
 #if defined(OS_MACOSX)
-    std::string new_tab_click_script =
-        "simulateClick(\"test-anchor-no-target\", { metaKey: true });";
+    const char* new_tab_click_script_template =
+        "simulateClick(\"%s\", { metaKey: true });";
 #else
-    std::string new_tab_click_script =
-        "simulateClick(\"test-anchor-no-target\", { ctrlKey: true });";
+    const char* new_tab_click_script_template =
+        "simulateClick(\"%s\", { ctrlKey: true });";
 #endif
+    const char* name_of_anchor_to_click = GetParam();
+    std::string new_tab_click_script = base::StringPrintf(
+        new_tab_click_script_template, name_of_anchor_to_click);
     EXPECT_TRUE(ExecuteScript(main_contents, new_tab_click_script));
 
     // Wait for a new tab to appear (the whole point of this test).
     new_contents = new_tab_observer.GetWebContents();
   }
 
   // Verify that the new tab has the right contents and is in the right, new
   // place in the tab strip.
   EXPECT_TRUE(WaitForLoadStop(new_contents));
   EXPECT_EQ(2, browser()->tab_strip_model()->count());
@@ skipping 38 matching lines @@
         "window.domAutomationController.send(w.location.href);",
         &location_of_opened_window));
     content::WebContents* found_contents =
         window_open_observer.GetWebContents();
     EXPECT_TRUE(WaitForLoadStop(found_contents));
     EXPECT_TRUE(found_contents->GetLastCommittedURL().IsAboutBlank());
     EXPECT_EQ(url::kAboutBlankURL, location_of_opened_window);
   }
 }
 
+INSTANTIATE_TEST_CASE_P(NoTarget,
+                        CtrlClickShouldEndUpInNewProcessTest,
+                        ::testing::Values("test-anchor-no-target"));
+INSTANTIATE_TEST_CASE_P(BlankTarget,
+                        CtrlClickShouldEndUpInNewProcessTest,
+                        ::testing::Values("test-anchor-with-blank-target"));
+INSTANTIATE_TEST_CASE_P(SubframeTarget,
+                        CtrlClickShouldEndUpInNewProcessTest,
+                        ::testing::Values("test-anchor-with-subframe-target"));
+
 class ChromeNavigationPortMappedBrowserTest : public InProcessBrowserTest {
  public:
   ChromeNavigationPortMappedBrowserTest() {}
   ~ChromeNavigationPortMappedBrowserTest() override {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     ASSERT_TRUE(embedded_test_server()->Start());
 
     // Use the command line parameter for the host resolver, so URLs without
     // explicit port numbers can be mapped under the hood to the port number
@@ skipping 48 matching lines @@
       browser()->tab_strip_model()->GetWebContentsAt(
           browser()->tab_strip_model()->count() - 1);
   WaitForLoadStop(new_web_contents);
 
   // If the test is unsuccessful, the return value from GetLastCommittedURL
   // will be the virtual URL for the created NavigationEntry.
   // Note: Before the bug was fixed, the URL was the new_tab_url with a scheme
   // prepended and one less ":" character after the host.
   EXPECT_EQ(GURL(), new_web_contents->GetLastCommittedURL());
 }