WebContents created via ctrl-click should be in a new process (target=_blank).

chrome/browser/chrome_navigation_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
@@ skipping 232 matching lines @@
     {
       // Double-check that main_contents has expected window.name set.
       // This is a sanity check of test setup; this is not a product test.
       std::string name_of_main_contents_window;
       EXPECT_TRUE(ExecuteScriptAndExtractString(
           main_contents, "window.domAutomationController.send(window.name)",
           &name_of_main_contents_window));
       EXPECT_EQ("main_contents", name_of_main_contents_window);
 
       // Verify that the new contents doesn't have a window.opener set.
-      bool window_opener_cast_to_bool;
+      bool window_opener_cast_to_bool = true;
       EXPECT_TRUE(ExecuteScriptAndExtractBool(
           new_contents, "window.domAutomationController.send(!!window.opener)",
           &window_opener_cast_to_bool));
       EXPECT_FALSE(window_opener_cast_to_bool);
 
       // Verify that the new contents cannot find the old contents via
       // window.open. (i.e. window.open should open a new window, rather than
       // returning a reference to main_contents / old window).
       std::string location_of_opened_window;
       EXPECT_TRUE(ExecuteScriptAndExtractString(
           new_contents,
           "w = window.open('', 'main_contents');"
           "window.domAutomationController.send(w.location.href);",
           &location_of_opened_window));
       EXPECT_EQ(url::kAboutBlankURL, location_of_opened_window);
     }
 
     return new_contents;
   }
+
+  void TestCtrlClick(const char* id_of_anchor_to_click) {
+    // Navigate to the test page.
+    GURL main_url(embedded_test_server()->GetURL(
+        "/frame_tree/anchor_to_same_site_location.html"));
+    ui_test_utils::NavigateToURL(browser(), main_url);
+
+    // Verify that there is only 1 active tab (with the right contents
+    // committed).
+    EXPECT_EQ(0, browser()->tab_strip_model()->active_index());
+    content::WebContents* main_contents =
+        browser()->tab_strip_model()->GetWebContentsAt(0);
+    EXPECT_EQ(main_url, main_contents->GetLastCommittedURL());
+
+    // Test what happens after ctrl-click.  SimulateCtrlClick will verify
+    // that |new_contents1| is in a separate process and browsing instance
+    // from |main_contents|.
+    content::WebContents* new_contents1 =
+        SimulateCtrlClick(main_contents, id_of_anchor_to_click);
+
+    // Test that each subsequent ctrl-click also gets a new process.
+    content::WebContents* new_contents2 =
+        SimulateCtrlClick(main_contents, id_of_anchor_to_click);
+    EXPECT_NE(new_contents1->GetMainFrame()->GetProcess(),
+              new_contents2->GetMainFrame()->GetProcess());
+    EXPECT_NE(new_contents1->GetMainFrame()->GetSiteInstance(),
+              new_contents2->GetMainFrame()->GetSiteInstance());
+    EXPECT_FALSE(new_contents1->GetSiteInstance()->IsRelatedSiteInstance(
+        new_contents2->GetSiteInstance()));
+  }
 };
 
 IN_PROC_BROWSER_TEST_F(CtrlClickShouldEndUpInNewProcessTest, NoTarget) {
-  // Navigate to the test page.
-  GURL main_url(embedded_test_server()->GetURL(
-      "/frame_tree/anchor_to_same_site_location.html"));
-  ui_test_utils::NavigateToURL(browser(), main_url);
-  const char* kIdOfAnchorToClick = "test-anchor-no-target";
+  TestCtrlClick("test-anchor-no-target");
+}
 
-  // Verify that there is only 1 active tab (with the right contents committed).
-  EXPECT_EQ(0, browser()->tab_strip_model()->active_index());
-  content::WebContents* main_contents =
-      browser()->tab_strip_model()->GetWebContentsAt(0);
-  EXPECT_EQ(main_url, main_contents->GetLastCommittedURL());
+IN_PROC_BROWSER_TEST_F(CtrlClickShouldEndUpInNewProcessTest, BlankTarget) {
+  TestCtrlClick("test-anchor-with-blank-target");
+}
 
-  // Test what happens after ctrl-click.  SimulateCtrlClick will verify
-  // that |new_contents1| is in a separate process and browsing instance
-  // from |main_contents|.
-  content::WebContents* new_contents1 =
-      SimulateCtrlClick(main_contents, kIdOfAnchorToClick);
-
-  // Test that each subsequent ctrl-click also gets a new process.
-  content::WebContents* new_contents2 =
-      SimulateCtrlClick(main_contents, kIdOfAnchorToClick);
-  EXPECT_NE(new_contents1->GetMainFrame()->GetProcess(),
-            new_contents2->GetMainFrame()->GetProcess());
-  EXPECT_NE(new_contents1->GetMainFrame()->GetSiteInstance(),
-            new_contents2->GetMainFrame()->GetSiteInstance());
-  EXPECT_FALSE(new_contents1->GetSiteInstance()->IsRelatedSiteInstance(
-      new_contents2->GetSiteInstance()));
+IN_PROC_BROWSER_TEST_F(CtrlClickShouldEndUpInNewProcessTest, SubframeTarget) {
+  TestCtrlClick("test-anchor-with-subframe-target");
 }
 
 class ChromeNavigationPortMappedBrowserTest : public InProcessBrowserTest {
  public:
   ChromeNavigationPortMappedBrowserTest() {}
   ~ChromeNavigationPortMappedBrowserTest() override {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     ASSERT_TRUE(embedded_test_server()->Start());
 
@@ skipping 104 matching lines @@
   // Let the navigation finish. It should commit successfully.
   manager.WaitForNavigationFinished();
   last_committed = web_contents->GetController().GetLastCommittedEntry();
   EXPECT_TRUE(last_committed);
   EXPECT_EQ(kURL2, last_committed->GetURL());
 
   EXPECT_TRUE(navigation_observer.has_committed());
   EXPECT_FALSE(navigation_observer.was_same_document());
   EXPECT_FALSE(navigation_observer.was_renderer_initiated());
 }