third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt - Issue 2680353005: WebContents created via ctrl-click should be in a new process (target=_blank).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt

Issue 2680353005: WebContents created via ctrl-click should be in a new process (target=_blank). (Closed)

Patch Set: Rebasing... Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 createView(done.html)	1 Default policy for navigation to 'done.html' is 'new background tab'
	Łukasz Anforowicz 2017/04/20 01:15:13 This comes from when we actually handle the middle This comes from when we actually handle the middle click and end up calling RenderFrameImpl::OpenURL. This is the part that we care about (i.e. we want the test to continue verifying that the link got opened in a new background tab).
	2 Default policy for navigation to 'done.html' is 'current tab'
	Łukasz Anforowicz 2017/04/20 01:15:13 This comes later, after the new tab got already cr This comes later, after the new tab got already created and when we are navigating the new tab to the expected URL.
2 This test opens a new window by middle-clicking on a link with target=_blank. It passes, if the WebViewClient::createView method was invoked with the parameter "done.html".	3 This test opens a new window by middle-clicking on a link with target=_blank. It passes, if the WebViewClient::createView method was invoked with the parameter "done.html".

3	4

4 link	5 link

OLD	NEW