content/public/browser/page_navigator.cc - Issue 2680353005: WebContents created via ctrl-click should be in a new process (target=_blank).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/browser/page_navigator.cc

Issue 2680353005: WebContents created via ctrl-click should be in a new process (target=_blank). (Closed)

Patch Set: Rebasing... Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/data/frame_tree/anchor_to_same_site_location.html ('k') | content/shell/browser/shell.cc » ('j') | third_party/WebKit/LayoutTests/fast/loader/middle-click-target-blank-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/public/browser/page_navigator.h"	5 #include "content/public/browser/page_navigator.h"

6	6

7 namespace content {	7 namespace content {

8	8

9 OpenURLParams::OpenURLParams(const GURL& url,	9 OpenURLParams::OpenURLParams(const GURL& url,

10 const Referrer& referrer,	10 const Referrer& referrer,

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 transition(transition),	56 transition(transition),

57 is_renderer_initiated(is_renderer_initiated),	57 is_renderer_initiated(is_renderer_initiated),

58 should_replace_current_entry(false),	58 should_replace_current_entry(false),

59 user_gesture(!is_renderer_initiated),	59 user_gesture(!is_renderer_initiated),

60 started_from_context_menu(false) {}	60 started_from_context_menu(false) {}

61	61

62 OpenURLParams::OpenURLParams()	62 OpenURLParams::OpenURLParams()

63 : uses_post(false),	63 : uses_post(false),

64 frame_tree_node_id(-1),	64 frame_tree_node_id(-1),

65 disposition(WindowOpenDisposition::UNKNOWN),	65 disposition(WindowOpenDisposition::UNKNOWN),

	66 use_new_renderer_for_new_contents(false),

66 transition(ui::PAGE_TRANSITION_LINK),	67 transition(ui::PAGE_TRANSITION_LINK),

67 is_renderer_initiated(false),	68 is_renderer_initiated(false),

68 should_replace_current_entry(false),	69 should_replace_current_entry(false),

69 user_gesture(true),	70 user_gesture(true),

70 started_from_context_menu(false) {}	71 started_from_context_menu(false) {}

71	72

72 OpenURLParams::OpenURLParams(const OpenURLParams& other) = default;	73 OpenURLParams::OpenURLParams(const OpenURLParams& other) = default;

73	74

74 OpenURLParams::~OpenURLParams() {	75 OpenURLParams::~OpenURLParams() {

75 }	76 }

76	77

77 } // namespace content	78 } // namespace content

OLD	NEW