Issue 268033003: Disable splice frames for codecs other than mp3 or vorbis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268033003: Disable splice frames for codecs other than mp3 or vorbis. (Closed)

Created:
6 years, 7 months ago by DaleCurtis

Modified:
6 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable splice frames for codecs other than mp3 or vorbis. CHECK failure crashes are still happening sadly, so reduce the scope of splice frame support. Vorbis isn't widely used with MSE except for YT experiments and MP3 has no shipping customers yet. So this should be narrow enough to minimize crashes while I triage. If not I'll reduce scope to just MP3 for the M36 release. BUG=356073, 369204 TEST=unittests still pass. TBR=acolwell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268122

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	media/filters/chunk_demuxer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	media/filters/chunk_demuxer.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

TBR'ing since it's a simple change and I'd like to get this in today before ...

6 years, 7 months ago (2014-05-04 18:13:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/268033003/1

6 years, 7 months ago (2014-05-04 18:14:23 UTC) #3

Message was sent while issue was closed.

Change committed as 268122

Expand Messages | Collapse Messages