Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2680323002: Handle operators correctly. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Lasse Reichstein Nielsen
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rename Operator.index to Operator.indexGet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -13 lines) Patch
A pkg/front_end/lib/src/fasta/operator.dart View 1 1 chunk +80 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 3 chunks +22 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/front_end/test/fasta/operators.dart View 1 chunk +51 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/operators.dart.direct.expect View 1 chunk +72 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/operators.dart.outline.expect View 1 chunk +50 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000053.dart.outline.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/testing.json View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
Patch set 1 is what was reverted.
3 years, 10 months ago (2017-02-08 14:49:12 UTC) #2
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-09 08:44:54 UTC) #3
ahe
3 years, 10 months ago (2017-02-09 12:04:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
616640d28b51820b5bfdccd24bd953143982ecff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698