Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: runtime/vm/kernel_to_il.h

Issue 2680303002: Kernel debugging; service tests (Closed)
Patch Set: Changes based on feedback. Also fixed regress_28443_test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/kernel_to_il.h
diff --git a/runtime/vm/kernel_to_il.h b/runtime/vm/kernel_to_il.h
index 211a61b029c1c2bcb95dbd333bee407bf1cb6bba..2dfc160d187f7cdff1c4c00b56bd10867886de8c 100644
--- a/runtime/vm/kernel_to_il.h
+++ b/runtime/vm/kernel_to_il.h
@@ -837,7 +837,7 @@ class FlowGraphBuilder : public ExpressionVisitor, public StatementVisitor {
intptr_t num_args_checked = 1);
Fragment ClosureCall(int argument_count, const Array& argument_names);
Fragment ThrowException(TokenPosition position);
- Fragment RethrowException(int catch_try_index);
+ Fragment RethrowException(TokenPosition position, int catch_try_index);
Fragment LoadClassId();
Fragment LoadField(const dart::Field& field);
Fragment LoadField(intptr_t offset, intptr_t class_id = kDynamicCid);
@@ -868,10 +868,11 @@ class FlowGraphBuilder : public ExpressionVisitor, public StatementVisitor {
bool is_initialization_store,
StoreBarrierType emit_store_barrier = kEmitStoreBarrier);
Fragment StoreInstanceField(
+ TokenPosition position,
intptr_t offset,
StoreBarrierType emit_store_barrier = kEmitStoreBarrier);
Fragment StoreLocal(TokenPosition position, LocalVariable* variable);
- Fragment StoreStaticField(const dart::Field& field);
+ Fragment StoreStaticField(TokenPosition position, const dart::Field& field);
Fragment StringInterpolate(TokenPosition position);
Fragment ThrowTypeError();
Fragment ThrowNoSuchMethodError();
@@ -886,6 +887,10 @@ class FlowGraphBuilder : public ExpressionVisitor, public StatementVisitor {
Fragment CheckAssignableInCheckedMode(const dart::AbstractType& dst_type,
const dart::String& dst_name);
+ bool NeedsDebugStepCheck(const Function& function, TokenPosition position);
+ bool NeedsDebugStepCheck(Value* value, TokenPosition position);
+ Fragment DebugStepCheck(TokenPosition position);
+
Fragment AssertBool();
Fragment AssertAssignable(const dart::AbstractType& dst_type,
const dart::String& dst_name);
@@ -971,6 +976,7 @@ class FlowGraphBuilder : public ExpressionVisitor, public StatementVisitor {
return scopes_->catch_context_variables[try_depth_];
}
+
// A chained list of breakable blocks. Chaining and lookup is done by the
// [BreakableBlock] class.
BreakableBlock* breakable_block_;

Powered by Google App Engine
This is Rietveld 408576698