runtime/observatory/tests/service/test_helper.dart - Issue 2680303002: Kernel debugging; service tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 2680303002: Kernel debugging; service tests (Closed)

Patch Set: Changes based on feedback. Also fixed regress_28443_test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/test_helper.dart

diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart

index e1f43af87aaf206766376a74a43ca944456440b5..a7d2528b2b237deb2351dfbf767c2807e4dd169c 100644

--- a/runtime/observatory/tests/service/test_helper.dart

+++ b/runtime/observatory/tests/service/test_helper.dart

@@ -488,3 +488,8 @@ Future runVMTests(List<String> mainArgs,

pause_on_unhandled_exceptions: pause_on_unhandled_exceptions);

}

+/// Whether we're running from kernel.

+bool isKernel(Isolate isolate) {

+ return isolate.name.contains(r".dill$");