pkg/kernel/lib/binary/ast_to_binary.dart - Issue 2680303002: Kernel debugging; service tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/kernel/lib/binary/ast_to_binary.dart

Issue 2680303002: Kernel debugging; service tests (Closed)

Patch Set: Changes based on feedback. Also fixed regress_28443_test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/kernel/lib/binary/ast_from_binary.dart ('k') | pkg/kernel/lib/transformations/continuation.dart » ('j') | runtime/observatory/tests/service/next_through_closure_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/kernel/lib/binary/ast_to_binary.dart

diff --git a/pkg/kernel/lib/binary/ast_to_binary.dart b/pkg/kernel/lib/binary/ast_to_binary.dart

index 6d3dabda980afd5aa453172db000a029a3974d87..bf9bb7db53dde0c5ea9f35cc71d58a8aff06157f 100644

--- a/pkg/kernel/lib/binary/ast_to_binary.dart

+++ b/pkg/kernel/lib/binary/ast_to_binary.dart

@@ -507,6 +507,7 @@ class BinaryPrinter extends Visitor {

visitStaticSet(StaticSet node) {

writeByte(Tag.StaticSet);

+ writeOffset(node, node.fileOffset);

writeMemberReference(node.target);

writeNode(node.value);

}

@@ -607,6 +608,7 @@ class BinaryPrinter extends Visitor {

visitAsExpression(AsExpression node) {

writeByte(Tag.AsExpression);

+ writeOffset(node, node.fileOffset);

writeNode(node.operand);

writeNode(node.type);

}

@@ -667,6 +669,7 @@ class BinaryPrinter extends Visitor {

visitRethrow(Rethrow node) {

writeByte(Tag.Rethrow);

+ writeOffset(node, node.fileOffset);

}

visitThrow(Throw node) {

@@ -677,6 +680,7 @@ class BinaryPrinter extends Visitor {

visitListLiteral(ListLiteral node) {

writeByte(node.isConst ? Tag.ConstListLiteral : Tag.ListLiteral);

+ writeOffset(node, node.fileOffset);

writeNode(node.typeArgument);

writeNodeList(node.expressions);

}

@@ -755,6 +759,7 @@ class BinaryPrinter extends Visitor {

visitBreakStatement(BreakStatement node) {

writeByte(Tag.BreakStatement);

+ writeOffset(node, node.fileOffset);

writeUInt30(_labelIndexer[node.target]);

}

@@ -858,6 +863,7 @@ class BinaryPrinter extends Visitor {

void writeVariableDeclaration(VariableDeclaration node) {

writeOffset(node, node.fileOffset);

+ writeOffset(node, node.fileEqualsOffset);

writeByte(node.flags);

writeStringReference(node.name ?? '');

writeNode(node.type);