Kernel debugging; service tests

runtime/vm/kernel_to_il.h

Index: runtime/vm/kernel_to_il.h
diff --git a/runtime/vm/kernel_to_il.h b/runtime/vm/kernel_to_il.h
index 211a61b029c1c2bcb95dbd333bee407bf1cb6bba..56ec5dbd619e564a64c3f4f60a94b923f3e45b67 100644
--- a/runtime/vm/kernel_to_il.h
+++ b/runtime/vm/kernel_to_il.h
@@ -286,6 +286,11 @@ class TranslationHelper {
   void ReportError(const char* format, ...);
   void ReportError(const Error& prev_error, const char* format, ...);
 
+  bool ShouldAddDebugInstruction(const Function& function,

[Kevin Millikin (Google), 2017/02/08 15:37:53]

Why are these in the translation helper instead of in the graph builder?  Do we
anticipate using them for something other than graph building?

[jensj, 2017/02/13 14:04:17]

I paid to little attention to the name; I just saw it as a place for utility
functions. I'll move it.

+                                 TokenPosition position);
+  bool ShouldAddDebugInstruction(Value* value, TokenPosition position);
+  Fragment GetDebugInstruction(TokenPosition position);

[Kevin Millikin (Google), 2017/02/08 15:37:53]

This one should definitely be in the graph builder.  It's just building a
fragment of a graph which doesn't make sense in any context outside of the graph
builder.

[jensj, 2017/02/13 14:04:17]

Done.

+
  private:
   // This will mangle [kernel_name] (if necessary) and make the result a symbol.
   // The result will be avilable in [name_to_modify] and it is also returned.
@@ -868,10 +873,11 @@ class FlowGraphBuilder : public ExpressionVisitor, public StatementVisitor {
       bool is_initialization_store,
       StoreBarrierType emit_store_barrier = kEmitStoreBarrier);
   Fragment StoreInstanceField(
+      TokenPosition position,
       intptr_t offset,
       StoreBarrierType emit_store_barrier = kEmitStoreBarrier);
   Fragment StoreLocal(TokenPosition position, LocalVariable* variable);
-  Fragment StoreStaticField(const dart::Field& field);
+  Fragment StoreStaticField(TokenPosition position, const dart::Field& field);
   Fragment StringInterpolate(TokenPosition position);
   Fragment ThrowTypeError();
   Fragment ThrowNoSuchMethodError();