Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: runtime/vm/kernel_binary.cc

Issue 2680303002: Kernel debugging; service tests (Closed)
Patch Set: New failing test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/kernel_binary.cc
diff --git a/runtime/vm/kernel_binary.cc b/runtime/vm/kernel_binary.cc
index dc5c5675ed696604d8a29a37383440907cee5cb3..71eceb9706dc7b3e4a4e6e1b308bb856b28df7a4 100644
--- a/runtime/vm/kernel_binary.cc
+++ b/runtime/vm/kernel_binary.cc
@@ -1152,6 +1152,7 @@ StaticGet* StaticGet::ReadFrom(Reader* reader) {
StaticSet* StaticSet::ReadFrom(Reader* reader) {
TRACE_READ_OFFSET();
StaticSet* set = new StaticSet();
+ set->position_ = reader->ReadPosition();
set->target_ = Reference::ReadMemberFrom(reader);
set->expression_ = Expression::ReadFrom(reader);
return set;
@@ -1272,6 +1273,7 @@ IsExpression* IsExpression::ReadFrom(Reader* reader) {
AsExpression* AsExpression::ReadFrom(Reader* reader) {
TRACE_READ_OFFSET();
AsExpression* expr = new AsExpression();
+ expr->position_ = reader->ReadPosition();
expr->operand_ = Expression::ReadFrom(reader);
expr->type_ = DartType::ReadFrom(reader);
return expr;
@@ -1370,6 +1372,7 @@ ListLiteral* ListLiteral::ReadFrom(Reader* reader, bool is_const) {
TRACE_READ_OFFSET();
ListLiteral* literal = new ListLiteral();
literal->is_const_ = is_const;
+ literal->position_ = reader->ReadPosition();
literal->type_ = DartType::ReadFrom(reader);
literal->expressions_.ReadFromStatic<Expression>(reader);
return literal;
@@ -1535,6 +1538,7 @@ LabeledStatement* LabeledStatement::ReadFrom(Reader* reader) {
BreakStatement* BreakStatement::ReadFrom(Reader* reader) {
TRACE_READ_OFFSET();
BreakStatement* stmt = new BreakStatement();
+ stmt->position_ = reader->ReadPosition();
stmt->target_ = reader->helper()->labels()->Lookup(reader->ReadUInt());
return stmt;
}
@@ -1715,6 +1719,7 @@ VariableDeclaration* VariableDeclaration::ReadFromImpl(Reader* reader) {
VariableDeclaration* decl = new VariableDeclaration();
decl->position_ = reader->ReadPosition();
+ decl->equals_position_ = reader->ReadPosition();
decl->flags_ = reader->ReadFlags();
decl->name_ = Reference::ReadStringFrom(reader);
decl->type_ = DartType::ReadFrom(reader);

Powered by Google App Engine
This is Rietveld 408576698