Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: pkg/kernel/lib/binary/ast_to_binary.dart

Issue 2680303002: Kernel debugging; service tests (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/binary/ast_from_binary.dart ('k') | pkg/kernel/lib/transformations/continuation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/binary/ast_to_binary.dart
diff --git a/pkg/kernel/lib/binary/ast_to_binary.dart b/pkg/kernel/lib/binary/ast_to_binary.dart
index a242338dfa7465858ffd90a70a722d55a2556579..a2deddb6a43398cb6668ac5931d174a1da6fe9e7 100644
--- a/pkg/kernel/lib/binary/ast_to_binary.dart
+++ b/pkg/kernel/lib/binary/ast_to_binary.dart
@@ -515,6 +515,7 @@ class BinaryPrinter extends Visitor {
visitStaticSet(StaticSet node) {
writeByte(Tag.StaticSet);
+ writeOffset(node, node.fileOffset);
writeReference(node.targetReference);
writeNode(node.value);
}
@@ -615,6 +616,7 @@ class BinaryPrinter extends Visitor {
visitAsExpression(AsExpression node) {
writeByte(Tag.AsExpression);
+ writeOffset(node, node.fileOffset);
writeNode(node.operand);
writeNode(node.type);
}
@@ -675,6 +677,7 @@ class BinaryPrinter extends Visitor {
visitRethrow(Rethrow node) {
writeByte(Tag.Rethrow);
+ writeOffset(node, node.fileOffset);
}
visitThrow(Throw node) {
@@ -685,6 +688,7 @@ class BinaryPrinter extends Visitor {
visitListLiteral(ListLiteral node) {
writeByte(node.isConst ? Tag.ConstListLiteral : Tag.ListLiteral);
+ writeOffset(node, node.fileOffset);
writeNode(node.typeArgument);
writeNodeList(node.expressions);
}
@@ -773,6 +777,7 @@ class BinaryPrinter extends Visitor {
visitBreakStatement(BreakStatement node) {
writeByte(Tag.BreakStatement);
+ writeOffset(node, node.fileOffset);
writeUInt30(_labelIndexer[node.target]);
}
@@ -876,6 +881,7 @@ class BinaryPrinter extends Visitor {
void writeVariableDeclaration(VariableDeclaration node) {
writeOffset(node, node.fileOffset);
+ writeOffset(node, node.fileEqualsOffset);
writeByte(node.flags);
writeStringReference(node.name ?? '');
writeNode(node.type);
« no previous file with comments | « pkg/kernel/lib/binary/ast_from_binary.dart ('k') | pkg/kernel/lib/transformations/continuation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698