Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: pkg/kernel/binary.md

Issue 2680303002: Kernel debugging; service tests (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/kernel/lib/analyzer/ast_from_analyzer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/binary.md
diff --git a/pkg/kernel/binary.md b/pkg/kernel/binary.md
index dc66d5d318d29b074b4269de304b34074f5e5337..71f3d9461824a429f1b36587f0112b3c744227a9 100644
--- a/pkg/kernel/binary.md
+++ b/pkg/kernel/binary.md
@@ -414,6 +414,7 @@ type StaticGet extends Expression {
type StaticSet extends Expression {
Byte tag = 27;
+ FileOffset fileOffset;
MemberReference target;
Expression value;
}
@@ -524,6 +525,7 @@ type IsExpression extends Expression {
type AsExpression extends Expression {
Byte tag = 38;
+ FileOffset fileOffset;
Expression operand;
DartType type;
}
@@ -586,6 +588,7 @@ type ThisExpression extends Expression {
type Rethrow extends Expression {
Byte tag = 47;
+ FileOffset fileOffset;
}
type Throw extends Expression {
@@ -596,12 +599,14 @@ type Throw extends Expression {
type ListLiteral extends Expression {
Byte tag = 49;
+ FileOffset fileOffset;
DartType typeArgument;
List<Expression> values;
}
type ConstListLiteral extends Expression {
Byte tag = 58; // Note: tag is out of order.
+ FileOffset fileOffset;
DartType typeArgument;
List<Expression> values;
}
@@ -686,6 +691,7 @@ type LabeledStatement extends Statement {
type BreakStatement extends Statement {
Byte tag = 66;
+ FileOffset fileOffset;
// Reference to the Nth LabeledStatement in scope, with 0 being the
// outermost enclosing labeled statement within the same FunctionNode.
@@ -801,7 +807,14 @@ type VariableDeclarationStatement extends Statement {
}
type VariableDeclaration {
+ // The offset for the variable declaration, i.e. the offset of the start of
+ // the declaration.
FileOffset fileOffset;
+
+ // The offset for the equal sign in the declaration (if it contains one).
+ // If it does not contain one this should be -1.
+ FileOffset fileEqualsOffset;
+
Byte flags (isFinal, isConst);
// For named parameters, this is the parameter name.
// For other variables, the name is cosmetic, may be empty,
« no previous file with comments | « no previous file | pkg/kernel/lib/analyzer/ast_from_analyzer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698