Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2643)

Unified Diff: pkg/kernel/lib/binary/ast_to_binary.dart

Issue 2680303002: Kernel debugging; service tests (Closed)
Patch Set: Correct file offset when calling on field (mind the rebase) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/lib/binary/ast_to_binary.dart
diff --git a/pkg/kernel/lib/binary/ast_to_binary.dart b/pkg/kernel/lib/binary/ast_to_binary.dart
index a137d86542196b7e7a2fc10099db832d817cad1a..25afe2d27d7ae60a06606fda0e8e4047c3f7c2ca 100644
--- a/pkg/kernel/lib/binary/ast_to_binary.dart
+++ b/pkg/kernel/lib/binary/ast_to_binary.dart
@@ -537,6 +537,7 @@ class BinaryPrinter extends Visitor {
visitStaticSet(StaticSet node) {
writeByte(Tag.StaticSet);
+ writeOffset(node, node.fileOffset);
writeMemberReference(node.target);
writeNode(node.value);
}
@@ -637,6 +638,7 @@ class BinaryPrinter extends Visitor {
visitAsExpression(AsExpression node) {
writeByte(Tag.AsExpression);
+ writeOffset(node, node.fileOffset);
writeNode(node.operand);
writeNode(node.type);
}
@@ -697,6 +699,7 @@ class BinaryPrinter extends Visitor {
visitRethrow(Rethrow node) {
writeByte(Tag.Rethrow);
+ writeOffset(node, node.fileOffset);
}
visitThrow(Throw node) {
@@ -707,6 +710,7 @@ class BinaryPrinter extends Visitor {
visitListLiteral(ListLiteral node) {
writeByte(node.isConst ? Tag.ConstListLiteral : Tag.ListLiteral);
+ writeOffset(node, node.fileOffset);
writeNode(node.typeArgument);
writeNodeList(node.expressions);
}
@@ -795,6 +799,7 @@ class BinaryPrinter extends Visitor {
visitBreakStatement(BreakStatement node) {
writeByte(Tag.BreakStatement);
+ writeOffset(node, node.fileOffset);
writeUInt30(_labelIndexer[node.target]);
}
@@ -898,6 +903,7 @@ class BinaryPrinter extends Visitor {
void writeVariableDeclaration(VariableDeclaration node) {
writeOffset(node, node.fileOffset);
+ writeOffset(node, node.fileEqualsOffset);
writeByte(node.flags);
writeStringReference(node.name ?? '');
writeNode(node.type);

Powered by Google App Engine
This is Rietveld 408576698