Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: pkg/kernel/binary.md

Issue 2680303002: Kernel debugging; service tests (Closed)
Patch Set: Correct file offset when calling on field (mind the rebase) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/kernel/lib/analyzer/ast_from_analyzer.dart » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/binary.md
diff --git a/pkg/kernel/binary.md b/pkg/kernel/binary.md
index 60596908fead59a521a0057dafb462780b73ff1e..3b8e43860cc365f11bdbe62e61b39386150f6191 100644
--- a/pkg/kernel/binary.md
+++ b/pkg/kernel/binary.md
@@ -448,6 +448,7 @@ type StaticGet extends Expression {
type StaticSet extends Expression {
Byte tag = 27;
+ FileOffset fileOffset;
MemberReference target;
Expression value;
}
@@ -558,6 +559,7 @@ type IsExpression extends Expression {
type AsExpression extends Expression {
Byte tag = 38;
+ FileOffset fileOffset;
Expression operand;
DartType type;
}
@@ -620,6 +622,7 @@ type ThisExpression extends Expression {
type Rethrow extends Expression {
Byte tag = 47;
+ FileOffset fileOffset;
}
type Throw extends Expression {
@@ -630,12 +633,14 @@ type Throw extends Expression {
type ListLiteral extends Expression {
Byte tag = 49;
+ FileOffset fileOffset;
DartType typeArgument;
List<Expression> values;
}
type ConstListLiteral extends Expression {
Byte tag = 58; // Note: tag is out of order.
+ FileOffset fileOffset;
DartType typeArgument;
List<Expression> values;
}
@@ -720,6 +725,7 @@ type LabeledStatement extends Statement {
type BreakStatement extends Statement {
Byte tag = 66;
+ FileOffset fileOffset;
// Reference to the Nth LabeledStatement in scope, with 0 being the
// outermost enclosing labeled statement within the same FunctionNode.
@@ -835,7 +841,14 @@ type VariableDeclarationStatement extends Statement {
}
type VariableDeclaration {
+ // The offset for the variable declaration, i.e. the offset of the start of
+ // the declaration.
FileOffset fileOffset;
+
+ // The offset for the equal sign in the declaration (if it contains one).
+ // If it does not contain one this should be -1.
+ FileOffset fileEqualsOffset;
+
Byte flags (isFinal, isConst);
// For named parameters, this is the parameter name.
// For other variables, the name is cosmetic, may be empty,
« no previous file with comments | « no previous file | pkg/kernel/lib/analyzer/ast_from_analyzer.dart » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698