Kernel debugging; service tests

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/become.h"
@@ skipping 9101 matching lines @@
       } else {
         min = midpoint;
       }
     }
     *line = min + 1;
     smi ^= line_starts_array.At(min);
     if (column != NULL) {
       *column = offset - smi.Value() + 1;
     }
     if (token_len != NULL) {
-      // We don't explicitly save this data.
-      // TODO(jensj): Load the source and attempt to find it from there.
+      // We don't explicitly save this data: Load the source
+      // and find it from there.
+      const String& source = String::Handle(zone, Source());
+      ASSERT(source.Length() >= offset);
       *token_len = 1;
+      for (intptr_t i = offset + 1; i < source.Length(); ++i, ++*token_len) {
+        uint16_t c = source.CharAt(i);
+        if ((c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') ||

[hausner, 2017/02/14 13:16:04]

You could use Scanner::IsIdentStartChar() and Scanner::IsIdentChar(). When the
VM scanner is eventually going away, a few basic functions will probably survive
because they are helpful in situations like this.

[jensj, 2017/02/14 13:23:54]

Kevin suggested the same thing, but the methods are private.
What do you prefer --- making them public, make Script a friend class or keep it
as is?

+            (c >= '0' && c <= '9') || c == '_' || c == '$') {
+          continue;
+        }
+        break;
+      }
     }
     return;
   }
 
   const TokenStream& tkns = TokenStream::Handle(zone, tokens());
   if (tkns.IsNull()) {
     ASSERT((Dart::vm_snapshot_kind() == Snapshot::kAppAOT));
     *line = -1;
     if (column != NULL) {
       *column = -1;
@@ skipping 13599 matching lines @@
   return UserTag::null();
 }
 
 
 const char* UserTag::ToCString() const {
   const String& tag_label = String::Handle(label());
   return tag_label.ToCString();
 }
 
 }  // namespace dart