Kernel debugging; service tests

runtime/vm/kernel_to_il.h

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_KERNEL_TO_IL_H_
 #define RUNTIME_VM_KERNEL_TO_IL_H_
 
 #if !defined(DART_PRECOMPILED_RUNTIME)
 
 #include "vm/growable_array.h"
@@ skipping 268 matching lines @@
   RawFunction* LookupConstructorByKernelConstructor(Constructor* constructor);
   dart::RawFunction* LookupConstructorByKernelConstructor(
       const dart::Class& owner,
       Constructor* constructor);
 
   dart::Type& GetCanonicalType(const dart::Class& klass);
 
   void ReportError(const char* format, ...);
   void ReportError(const Error& prev_error, const char* format, ...);
 
+  bool ShouldAddDebugInstruction(const Function& function,

[Kevin Millikin (Google), 2017/02/08 15:37:53]

Why are these in the translation helper instead of in the graph builder?  Do we
anticipate using them for something other than graph building?

[jensj, 2017/02/13 14:04:17]

I paid to little attention to the name; I just saw it as a place for utility
functions. I'll move it.

+                                 TokenPosition position);
+  bool ShouldAddDebugInstruction(Value* value, TokenPosition position);
+  Fragment GetDebugInstruction(TokenPosition position);

[Kevin Millikin (Google), 2017/02/08 15:37:53]

This one should definitely be in the graph builder.  It's just building a
fragment of a graph which doesn't make sense in any context outside of the graph
builder.

[jensj, 2017/02/13 14:04:17]

Done.

+
  private:
   // This will mangle [kernel_name] (if necessary) and make the result a symbol.
   // The result will be avilable in [name_to_modify] and it is also returned.
   dart::String& ManglePrivateName(Library* kernel_library,
                                   dart::String* name_to_modify,
                                   bool symbolize = true);
 
   dart::Thread* thread_;
   dart::Zone* zone_;
   dart::Isolate* isolate_;
@@ skipping 562 matching lines @@
                       intptr_t argument_count,
                       const Array& argument_names);
   Fragment StoreIndexed(intptr_t class_id);
   Fragment StoreInstanceFieldGuarded(const dart::Field& field,
                                      bool is_initialization_store);
   Fragment StoreInstanceField(
       const dart::Field& field,
       bool is_initialization_store,
       StoreBarrierType emit_store_barrier = kEmitStoreBarrier);
   Fragment StoreInstanceField(
+      TokenPosition position,
       intptr_t offset,
       StoreBarrierType emit_store_barrier = kEmitStoreBarrier);
   Fragment StoreLocal(TokenPosition position, LocalVariable* variable);
-  Fragment StoreStaticField(const dart::Field& field);
+  Fragment StoreStaticField(TokenPosition position, const dart::Field& field);
   Fragment StringInterpolate(TokenPosition position);
   Fragment ThrowTypeError();
   Fragment ThrowNoSuchMethodError();
   Fragment BuildImplicitClosureCreation(const Function& target);
   Fragment GuardFieldLength(const dart::Field& field, intptr_t deopt_id);
   Fragment GuardFieldClass(const dart::Field& field, intptr_t deopt_id);
 
   Fragment EvaluateAssertion();
   Fragment CheckReturnTypeInCheckedMode();
   Fragment CheckVariableTypeInCheckedMode(VariableDeclaration* variable);
@@ skipping 137 matching lines @@
 namespace kernel {
 
 RawObject* EvaluateMetadata(TreeNode* const kernel_node);
 RawObject* BuildParameterDescriptor(TreeNode* const kernel_node);
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)
 #endif  // RUNTIME_VM_KERNEL_TO_IL_H_