runtime/vm/hash_map.h - Issue 2680213002: Updated MallocHooks to collect stack traces when memory is allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/hash_map.h

Issue 2680213002: Updated MallocHooks to collect stack traces when memory is allocated. (Closed)

Patch Set: Added tests and modified stack walker to allow for skipping an arbitrary number of frames before co… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/hash_map.h

diff --git a/runtime/vm/hash_map.h b/runtime/vm/hash_map.h

index 6526acaf5c6b81f5c065e78ca06a10ceea543c2f..f98b392033ab43b3386ab759b1bc506e54a454f9 100644

--- a/runtime/vm/hash_map.h

+++ b/runtime/vm/hash_map.h

@@ -27,7 +27,7 @@ class BaseDirectChainedHashMap : public B {

BaseDirectChainedHashMap(const BaseDirectChainedHashMap& other);

- ~BaseDirectChainedHashMap() {

+ virtual ~BaseDirectChainedHashMap() {

allocator_->template Free<HashMapListElement>(array_, array_size_);

allocator_->template Free<HashMapListElement>(lists_, lists_size_);

}