action_derivedsourcesallinone.py: Fix Python style and conditional bug

action_derivedsourcesallinone.py: Fix Python style and conditional bug

This fixes Python style in action_derivedsourcesallinone.py
per Eric's request:
https://codereview.chromium.org/24053003/#msg35

It also makes the code more Pythonic and a bit better-factored,
though it's admittedly not esp. beautiful.

I also noticed that the code was broken, due mostly to a wrong regex,
so I've fixed that so it now inserts if/endif conditionals into
derived sources.
HOWEVER, this makes linking fail (in SVGs), so turned off for now.
(This hasn't worked for a while.)
The code is fixed, so it's just a question of figuring out the
conditional problem and turning it back on
(or removing this code).

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159445

[Nils Barth (inactive), 2013-10-10 08:36:34]

Hi Eric,
Here's a cleanup to your (well-founded) nits.
How does it look?

[Nils Barth (inactive), 2013-10-10 08:39:02]

BTW, haraken, as you've also hacked on this,
feel free to take a look or grab this review!

[haraken, 2013-10-10 08:57:41]

LGTM

Not related to your CL, I suspect that the shard number of derived sources is
too small (Currently the shard number is 19). To increase the parallelism of
complication and improve build performance, we might want to increase the
shards.

[Nils Barth (inactive), 2013-10-10 09:00:57]

On 2013/10/10 08:57:41, haraken wrote:
> LGTM

Thanks!
(OWNERS?)


> Not related to your CL, I suspect that the shard number of derived sources is
> too small (Currently the shard number is 19). To increase the parallelism of
> complication and improve build performance, we might want to increase the
> shards.

This is an easy change, but we'd probably want to do a bit of profiling around
it
to get a sensible number, which might take a bit of time.
Shall I do this when I'm working on dependencies/speeding up the build
generally?

[eseidel, 2013-10-10 14:44:47]

lgtm

https://codereview.chromium.org/26802002/diff/2/Source/build/scripts/action_d...
File Source/build/scripts/action_derivedsourcesallinone.py (right):

https://codereview.chromium.org/26802002/diff/2/Source/build/scripts/action_d...
Source/build/scripts/action_derivedsourcesallinone.py:162: os.mkdir(parent_path)
This probably won't do what the author intends. Mktree would though

[Nils Barth (inactive), 2013-10-11 01:58:36]

https://codereview.chromium.org/26802002/diff/2/Source/build/scripts/action_d...
File Source/build/scripts/action_derivedsourcesallinone.py (right):

https://codereview.chromium.org/26802002/diff/2/Source/build/scripts/action_d...
Source/build/scripts/action_derivedsourcesallinone.py:162: os.mkdir(parent_path)
On 2013/10/10 14:44:47, eseidel wrote:
> This probably won't do what the author intends. Mktree would though 

Good point (rather, os.makedirs).
This making directories is probably unnecessary
(on Linux it's the dir is always gen/blink/bindings),
so we could just open the file and remove this function.
However, it might be needed on Windows, so leaving for now.

[commit-bot: I haz the power, 2013-10-11 01:59:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/26802002/13001

[commit-bot: I haz the power, 2013-10-11 02:25:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_blink_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-11 02:31:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/26802002/13001

[commit-bot: I haz the power, 2013-10-11 02:39:09]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-11 02:42:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/26802002/13001

[commit-bot: I haz the power, 2013-10-11 02:52:36]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_blink_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Nils Barth (inactive), 2013-10-11 03:06:57]

On 2013/10/11 02:52:36, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on linux_blink_rel.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

Looking at stdio, linking fails on SVG
(which is one of the [Conditional] values that occurs for interfaces:
SVG_FONTS)
...so turning *off* the behavior change for now.
Code is corrected, so if we want to fix this it's easy to flip it on,
but it's orthogonal to code cleanup and correction.

[commit-bot: I haz the power, 2013-10-11 03:07:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/26802002/17001

[commit-bot: I haz the power, 2013-10-11 07:11:20]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-11 08:09:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/26802002/17001

[commit-bot: I haz the power, 2013-10-11 11:15:40]

Change committed as 159445