components/password_manager/content/browser/content_password_manager_driver.h - Issue 2680163006: Eliminate PasswordAutofillAgentConstructed() in mojo interface PasswordManagerDriver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.h

Issue 2680163006: Eliminate PasswordAutofillAgentConstructed() in mojo interface PasswordManagerDriver (Closed)

Patch Set: Address comments from vabr@ Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc ('k') | components/password_manager/content/browser/content_password_manager_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver.h

diff --git a/components/password_manager/content/browser/content_password_manager_driver.h b/components/password_manager/content/browser/content_password_manager_driver.h

index b446835f741fce79e793a22c3a1d3f009572d7ba..d7ddb70ccad703f4d52e2e180bbc844807cb8b2f 100644

--- a/components/password_manager/content/browser/content_password_manager_driver.h

+++ b/components/password_manager/content/browser/content_password_manager_driver.h

@@ -104,7 +104,6 @@ class ContentPasswordManagerDriver

const gfx::RectF& bounds) override;

void ShowNotSecureWarning(base::i18n::TextDirection text_direction,

const gfx::RectF& bounds) override;

- void PasswordAutofillAgentConstructed() override;

void RecordSavePasswordProgress(const std::string& log) override;

void SaveGenerationFieldDetectedByClassifier(

const autofill::PasswordForm& password_form,