Eliminate PasswordAutofillAgentConstructed() in mojo interface PasswordManagerDriver

components/password_manager/content/browser/content_password_manager_driver_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/content_password_manager_driver.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "components/autofill/content/common/autofill_agent.mojom.h"
@@ skipping 113 matching lines @@
   }
 
  protected:
   MockLogManager log_manager_;
   MockPasswordManagerClient password_manager_client_;
   autofill::TestAutofillClient autofill_client_;
 
   FakePasswordAutofillAgent fake_agent_;
 };
 
-TEST_P(ContentPasswordManagerDriverTest,
-       AnswerToNotificationsAboutLoggingState) {
+TEST_P(ContentPasswordManagerDriverTest, SendLoggingStateInCtor) {
   const bool should_allow_logging = GetParam();
+  EXPECT_CALL(log_manager_, IsLoggingActive())
+      .WillRepeatedly(Return(should_allow_logging));
   std::unique_ptr<ContentPasswordManagerDriver> driver(
       new ContentPasswordManagerDriver(main_rfh(), &password_manager_client_,
                                        &autofill_client_));
 
-  EXPECT_CALL(log_manager_, IsLoggingActive())
-      .WillRepeatedly(Return(should_allow_logging));
-  driver->SendLoggingAvailability();
   if (should_allow_logging) {
     bool logging_activated = false;
     EXPECT_TRUE(WasLoggingActivationMessageSent(&logging_activated));
     EXPECT_TRUE(logging_activated);
   } else {
     bool logging_activated = true;
     EXPECT_TRUE(WasLoggingActivationMessageSent(&logging_activated));
     EXPECT_FALSE(logging_activated);
   }
 }
 
-TEST_P(ContentPasswordManagerDriverTest, AnswerToIPCPingsAboutLoggingState) {
+TEST_P(ContentPasswordManagerDriverTest, SendLoggingStateAfterLogManagerReady) {
   const bool should_allow_logging = GetParam();
+  EXPECT_CALL(password_manager_client_, GetLogManager())
+      .WillOnce(Return(nullptr));
   std::unique_ptr<ContentPasswordManagerDriver> driver(
       new ContentPasswordManagerDriver(main_rfh(), &password_manager_client_,
                                        &autofill_client_));
+  // Because log manager is not ready yet, should have no logging state sent.
+  EXPECT_FALSE(WasLoggingActivationMessageSent(nullptr));
 
+  // Log manager is ready, send logging state actually.
+  EXPECT_CALL(password_manager_client_, GetLogManager())
+      .WillOnce(Return(&log_manager_));
   EXPECT_CALL(log_manager_, IsLoggingActive())
       .WillRepeatedly(Return(should_allow_logging));
   driver->SendLoggingAvailability();
-  WasLoggingActivationMessageSent(nullptr);
-
-  // Ping the driver for logging activity update.
-  driver->PasswordAutofillAgentConstructed();
-
   bool logging_activated = false;
   EXPECT_TRUE(WasLoggingActivationMessageSent(&logging_activated));
   EXPECT_EQ(should_allow_logging, logging_activated);
 }
 
 // Tests that password visibility notifications are forwarded to the
 // WebContents.
 TEST_P(ContentPasswordManagerDriverTest, PasswordVisibility) {
   std::unique_ptr<ContentPasswordManagerDriver> driver(
       new ContentPasswordManagerDriver(main_rfh(), &password_manager_client_,
@@ skipping 185 matching lines @@
   old_rfh_tester->SimulateSwapOutACK();
   EXPECT_TRUE(!!(entry->GetSSL().content_status &
                  content::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP));
 }
 
 INSTANTIATE_TEST_CASE_P(,
                         ContentPasswordManagerDriverTest,
                         testing::Values(true, false));
 
 }  // namespace password_manager